Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link to docs on the monitor tab #929

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

FloydJohn
Copy link
Contributor

Which problem is this PR solving?

Resolves #928

Short description of the changes

  • This commit fixes a broken link on the empty state banner of the monitor page.

This commit fixes a broken link on the empty state banner of the monitor page.

Signed-off-by: Alessandro Racheli <alessandroracheli@gmail.com>
@albertteoh
Copy link
Contributor

Thanks @FloydJohn; can you please update the test as well?

$ yarn coverage
...
Summary of all failing tests
 FAIL  src/components/Monitor/ServicesView/index.test.js
  ● <MonitorATMServicesView> › ATM snapshot test with no metrics

    expect(value).toMatchSnapshot()

    Received value does not match stored snapshot "<MonitorATMServicesView> ATM snapshot test with no metrics 1".

    - Snapshot
    + Received

    @@ -4,11 +4,15 @@
            <React.Fragment>
              No data yet! Please see these
              <Link
                replace={false}
                target="_blank"
    -           to="//https://www.jaegertracing.io/docs/latest/spm/"
    +           to={
    +             Object {
    +               "pathname": "https://www.jaegertracing.io/docs/latest/spm/",
    +             }
    +           }

This commit updates the related snapshot tests.

Signed-off-by: Alessandro Racheli <alessandroracheli@gmail.com>
@FloydJohn
Copy link
Contributor Author

Done!

@albertteoh albertteoh enabled auto-merge (squash) April 13, 2022 11:22
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #929 (12c2ea0) into main (53da5e6) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #929      +/-   ##
==========================================
+ Coverage   95.25%   95.32%   +0.06%     
==========================================
  Files         240      240              
  Lines        7510     7510              
  Branches     1883     1883              
==========================================
+ Hits         7154     7159       +5     
+ Misses        350      345       -5     
  Partials        6        6              
Impacted Files Coverage Δ
...r-ui/src/components/Monitor/ServicesView/index.tsx 97.05% <ø> (ø)
...mponents/TracePage/TraceStatistics/tableValues.tsx 95.51% <0.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53da5e6...12c2ea0. Read the comment docs.

@albertteoh albertteoh merged commit 5d05a79 into jaegertracing:main Apr 13, 2022
@FloydJohn FloydJohn deleted the fix/monitor-tab-info-link branch April 13, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

instructions notify in Monitor Tab is undefined
2 participants