Support search by trace IDs #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saminzadeh
reviewed
Mar 24, 2017
| @@ -246,6 +253,7 @@ const mapStateToProps = state => { | |||
| maxDuration, | |||
| minDuration, | |||
| lookback, | |||
| traceID: traceIDParams, | |||
There was a problem hiding this comment.
What is the format of the URL here?
traceID=1&traceID=2 or traceID=1,2
If the later, let's use traceIDs
There was a problem hiding this comment.
the format is traceID=1&traceID=2, same as with tags
saminzadeh
reviewed
Mar 24, 2017
tiffon
pushed a commit
that referenced
this pull request
Mar 12, 2019
…ests-once-new-version-of-enzyme-is-released Update enzyme, Re-enable and add TraceDiff and TracePage tests
vvvprabhakar
referenced
this pull request
in vvvprabhakar/jaeger-ui
Jul 5, 2021
Support search by trace IDs Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar
referenced
this pull request
in vvvprabhakar/jaeger-ui
Jul 5, 2021
…ests-once-new-version-of-enzyme-is-released Update enzyme, Re-enable and add TraceDiff and TracePage tests Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.