Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to config #1007

Merged
merged 2 commits into from
Oct 23, 2022
Merged

Conversation

yurishkuro
Copy link
Member

  • add documentation to configuration type
  • rearrange config properties (move undocumented features down)
  • sync the order of default config with the type declaration

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Base: 95.33% // Head: 95.30% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (95cd83c) compared to base (7896ab5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1007      +/-   ##
==========================================
- Coverage   95.33%   95.30%   -0.03%     
==========================================
  Files         243      243              
  Lines        7561     7561              
  Branches     1895     1895              
==========================================
- Hits         7208     7206       -2     
- Misses        346      348       +2     
  Partials        7        7              
Impacted Files Coverage Δ
...ackages/jaeger-ui/src/constants/default-config.tsx 66.66% <ø> (ø)
...mponents/TracePage/TraceStatistics/tableValues.tsx 93.79% <0.00%> (-0.69%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro yurishkuro merged commit d38bccc into jaegertracing:main Oct 23, 2022
@yurishkuro yurishkuro deleted the config-docs branch October 23, 2022 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant