Handle FOLLOWS_FROM ref type #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
tiffon
requested review from
black-adder,
vprithvi,
yurishkuro and
saminzadeh
Signed-off-by: Joe Farro <joef@uber.com>
yurishkuro
approved these changes
Nov 2, 2017
NicolasT
reviewed
Nov 2, 2017
| @@ -0,0 +1,52 @@ | |||
| { | |||
There was a problem hiding this comment.
@NicolasT Great catch, thanks!
Signed-off-by: Joe Farro <joef@uber.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* Handle FOLLOWS_FROM refs when making span tree * Add test-case for issue jaegertracing#115 * Handle FOLLOWS_FROM in scrolling shortcuts Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115.
Fixes a regression from #53 where
FOLLOWS_FROMreferences throw an error. They're now treated the same asCHILD_OF.