Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tab from JSON File to Upload #1308

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

yurishkuro
Copy link
Member

  • Upload is a more intuitive name for the tab.

Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.05 🎉

Comparison is base (590cf8c) 95.51% compared to head (45836c9) 95.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1308      +/-   ##
==========================================
+ Coverage   95.51%   95.56%   +0.05%     
==========================================
  Files         244      244              
  Lines        7651     7651              
  Branches     2006     2006              
==========================================
+ Hits         7308     7312       +4     
+ Misses        343      339       -4     
Impacted Files Coverage Δ
...jaeger-ui/src/components/SearchTracePage/index.jsx 88.09% <ø> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro yurishkuro merged commit 4d189b6 into jaegertracing:main Mar 28, 2023
@yurishkuro yurishkuro deleted the s-json-file-to-upload branch March 28, 2023 00:09
Binrix pushed a commit to Binrix/jaeger-ui that referenced this pull request Apr 18, 2023
- Upload is a more intuitive name for the tab.

Signed-off-by: Yuri Shkuro <github@ysh.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant