Better HTTP error messages #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
tiffon
requested review from
black-adder,
vprithvi,
yurishkuro and
saminzadeh
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
==========================================
+ Coverage 92.16% 92.35% +0.19%
==========================================
Files 81 82 +1
Lines 1799 1832 +33
Branches 348 356 +8
==========================================
+ Hits 1658 1692 +34
+ Misses 129 128 -1
Partials 12 12
Continue to review full report at Codecov.
|
|
Looks like there are some changes that leaked into here that are just prettier formatted changes. I think its better to have this come in a new diff so the changes are only related to the Error formatting components |
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
… issue-127-fix-http-error-messages-simple
|
@saminzadeh Done. I reverted and then isolated the changes. |
saminzadeh
approved these changes
Dec 19, 2017
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* Better error messages on failed HTTP requests Signed-off-by: Joe Farro <joef@uber.com> * Prettier reformatting Signed-off-by: Joe Farro <joef@uber.com> * Better error formatting Signed-off-by: Joe Farro <joef@uber.com> * Update README to refer to codecov.io Signed-off-by: Joe Farro <joef@uber.com> * Unit tests for better HTTP error messages Signed-off-by: Joe Farro <joef@uber.com> * Better error messages on failed HTTP requests Signed-off-by: Joe Farro <joef@uber.com> * Better error formatting Signed-off-by: Joe Farro <joef@uber.com> * Update README to refer to codecov.io Signed-off-by: Joe Farro <joef@uber.com> * Unit tests for better HTTP error messages Signed-off-by: Joe Farro <joef@uber.com> * Revert to master Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127.
Fixes jaegertracing/jaeger#418.
Partially addresses jaegertracing/jaeger#401.
Improved HTTP error messages. No longer always showing the same often incorrect error message.
"Response body" is the first 1021 characters (with "..." appended when truncated).