Support in-page-search in trace view on key=value pairs

[bobrik]

Previously one could only filter on key or value. This wasn't useful when one needed to find spans with result=false in a trace view.

With this change one can use key=value as a search term, for example:

• http.method=GET

Before (no matches):

After (a successful match):

[bobrik]

I'm happy to add tests if this addition makes sense.

[yurishkuro]

a bit dirty (i.e. would also match on value="a=b"), but seems useful regardless. +1

[yurishkuro]

Overall the in-page search functionality is not very discoverable. When it was just a direct string match it was less of an issue, but if supporting a=b format it would be good to have some help tip somewhere.

Q: in the backend search form we support multiple space-separated tag queries, would be nice to allow the same syntax for in-page search. I believe we even have a parser for the syntax in the UI.

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03 ⚠️

Comparison is base (9924af6) 95.60% compared to head (2ddc2b3) 95.58%.

❗ Current head 2ddc2b3 differs from pull request most recent head df89c77. Consider uploading reports for the commit df89c77 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1391      +/-   ##
==========================================
- Coverage   95.60%   95.58%   -0.03%     
==========================================
  Files         244      244              
  Lines        7653     7657       +4     
  Branches     2006     2008       +2     
==========================================
+ Hits         7317     7319       +2     
- Misses        336      338       +2     

Impacted Files	Coverage Δ
...s/TracePage/TracePageHeader/TracePageSearchBar.tsx	100.00% <100.00%> (ø)
packages/jaeger-ui/src/utils/filter-spans.tsx	96.77% <100.00%> (+0.22%)	⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[bobrik]

I added some tests for the key=value syntax.

Here's the tooltip I added in the second commit:

Using the same syntax as the tag filter on the search page would mean that we lose -field syntax, so it might not be a desired change. Trace view search also looks at more things than just tags, which might not be compatible with what we have in the regular search. I'd also say that it's outside of my expertise, since I'm not a frontend person.

[bobrik]

@yurishkuro, any comments on the latest update?

[yurishkuro]

I rewrote the tooltip to make the explanation a bit more clear and to remove the styling applied to some key words which was difficult to read on the dark background.

[yurishkuro]

Sorry it took a while to review, a busy month.