Add a config value for the DAG cutoff #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
tiffon
requested review from
black-adder,
vprithvi,
yurishkuro,
pavolloffay and
saminzadeh
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
==========================================
+ Coverage 92.72% 93.04% +0.31%
==========================================
Files 82 85 +3
Lines 1829 1854 +25
Branches 353 359 +6
==========================================
+ Hits 1696 1725 +29
+ Misses 122 119 -3
+ Partials 11 10 -1
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Dec 19, 2017
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| export default 100; |
There was a problem hiding this comment.
why is it better to have one constant per file rather than list them all in one file?
There was a problem hiding this comment.
That's a valid point. I'll make the change.
Signed-off-by: Joe Farro <joef@uber.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
…fig-for-dag-max Add a config value for the DAG cutoff Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130 by adding
dependencies.dagMaxNumServicesUI config property.Also adds deprecations for config properties.
TLDR; I moved a config property but it's backwards compatible.
Seemed to make sense to group dependencies UI config values in a
dependenciestop-level property rather than having two top-level properties for it. So, I addeddeprecationswhich is an Array of old/new config property names. ThegetConfig()function moves old settings to the new property name unless there is a conflict. The first time this happens there is a warning issued to the console.