Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump typescript from 5.0.4 to 5.1.3 #1460

Merged
merged 3 commits into from
Jun 10, 2023
Merged

Bump typescript from 5.0.4 to 5.1.3 #1460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
109930d
Bump typescript from 5.0.4 to 5.1.3
dependabot[bot] Jun 9, 2023
8a8c7e8
Fix error TS2454: Variable 'warn' is used before being assigned.
yurishkuro Jun 10, 2023
a59f82b
Merge branch 'main' into dependabot/npm_and_yarn/typescript-5.1.3
yurishkuro Jun 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"npm-run-all": "4.1.5",
"prettier": "2.8.8",
"rxjs-compat": "6.6.7",
"typescript": "5.0.4"
"typescript": "5.1.3"
},
"resolutions": {
"**/lodash": "4.17.21"
Expand Down
3 changes: 2 additions & 1 deletion packages/plexus/src/LayoutManager/getLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ function getVerticesValidity(
const word = missingKeys.length > 1 ? 'vertices' : 'vertex';
return { validity: EValidity.Error, message: `Missing ${word}: ${missingKeys.join(', ')}` };
}
return warn || { validity: EValidity.Ok, message: null };
warn ??= { validity: EValidity.Ok, message: null };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes error TS2454: Variable 'warn' is used before being assigned.

return warn;
}

export default function getLayout(
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13108,10 +13108,10 @@ typedarray@^0.0.6:
version "0.0.6"
resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"

typescript@5.0.4:
version "5.0.4"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.0.4.tgz#b217fd20119bd61a94d4011274e0ab369058da3b"
integrity sha512-cW9T5W9xY37cc+jfEnaUvX91foxtHkza3Nw3wkoF4sSlKn0MONdkdEndig/qPBWXNkmplh3NzayQzCiHM4/hqw==
typescript@5.1.3:
version "5.1.3"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.1.3.tgz#8d84219244a6b40b6fb2b33cc1c062f715b9e826"
integrity sha512-XH627E9vkeqhlZFQuL+UsyAXEnibT0kWR2FWONlr4sTjvxyJYnyefgrkyECLzM5NenmKzRAy2rR/OlYLA1HkZw==

"typescript@^3 || ^4":
version "4.8.4"
Expand Down