Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling file upload via site config #1464

Merged
merged 4 commits into from
Jun 4, 2023
Merged

Allow disabling file upload via site config #1464

merged 4 commits into from
Jun 4, 2023

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jun 4, 2023 •
edited
Loading

@yurishkuro
Allow disabling file upload via site config
292857e 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
delint
4a46444 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Jun 4, 2023 •
edited
Loading

Codecov Report

Patch coverage: 66.66% and no project coverage change.

Comparison is base (4ea4742) 95.58% compared to head (bf31ed5) 95.58%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1464   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files         244      244           
  Lines        7657     7660    +3     
  Branches     2008     2010    +2     
=======================================
+ Hits         7319     7322    +3     
  Misses        338      338
Impacted Files Coverage Δ
...ackages/jaeger-ui/src/constants/default-config.tsx 75.00% <ø> (ø)
...jaeger-ui/src/components/SearchTracePage/index.jsx 88.50% <66.66%> (+0.41%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yurishkuro
add tests
d0fc4a0 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
order
bf31ed5 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro merged commit 6ed89d7 into jaegertracing:main Jun 4, 2023
7 of 8 checks passed
@yurishkuro yurishkuro deleted the disableFileUploadControl branch June 4, 2023 23:32
@yurishkuro yurishkuro mentioned this pull request Jun 4, 2023
Closed
ramumanam pushed a commit to ramumanam/jaeger-ui that referenced this pull request Jun 6, 2023
@yurishkuro @ramumanam
Allow disabling file upload via site config (jaegertracing#1464)
d12f1e0 
* This PR splits one single feature from jaegertracing#1229 by @Binrix, which is too
large
* Adds a new configuration option `disableFileUploadControl`
* Addresses part of jaegertracing#1211

---------

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: RAMU MANAM <manam.ramu@uber.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everett980 everett980 Awaiting requested review from everett980

@rubenvp8510 rubenvp8510 Awaiting requested review from rubenvp8510

@tiffon tiffon Awaiting requested review from tiffon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@yurishkuro