-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 9 - Span timeline not compatible with Safari #15
Fix issue 9 - Span timeline not compatible with Safari #15
Conversation
@@ -198,10 +198,8 @@ TimelineRow.Left.propTypes = { | |||
TimelineRow.Right = props => { | |||
const { children, ...rest } = props; | |||
return ( | |||
<div className="col-xs-9" {...rest}> | |||
<div className="relative" style={{ height: '100%' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was the height
not necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the
<div className="relative" style={{ height: '100%' }}>
It was necessary (due to the relative
). But, it is not needed on the
<div className="col-xs-9 relative" {...rest}>
@saminzadeh could you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just tested Safari, Chrome and Firefox.
Thanks!
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Resolves the issue with the span timeline view in Safari.
Edited UI view in Chrome and Safari are attached.
Chrome:
Safari: