Add text label to copy buttons on tags #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yushmanth <pali@pali-reddy.com>
Yushmanth-reddy
force-pushed
the
making-compact-copy-buttons
branch
from
a87f8a3
to
77ff340
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1547 +/- ##
=======================================
Coverage 95.96% 95.96%
=======================================
Files 242 242
Lines 7557 7557
Branches 1984 1984
=======================================
Hits 7252 7252
Misses 305 305
☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Jul 6, 2023
| /> | ||
| <CopyIcon | ||
| className="KeyValueTable--copyIcon" | ||
| className="KeyValueTable--copyIcon copyIcon" |
There was a problem hiding this comment.
copyIcon - why is this needed? It's not even defined in the css file.
There was a problem hiding this comment.
Sorry my bad I thought to use it in css of keyValueTable.css but later realised to use the css of Copyicon.css. Finally it is of no use.Let me make the changes.
Signed-off-by: Yushmanth <pali@pali-reddy.com>
Yushmanth-reddy
force-pushed
the
making-compact-copy-buttons
branch
from
012e08c
to
33123d1
Compare
yurishkuro
approved these changes
Jul 7, 2023
yurishkuro
changed the title
anikdhabal
pushed a commit
to anikdhabal/jaeger-ui
that referenced
this pull request
Jul 14, 2023
Signed-off-by: Anik Dhabal Babu <adhabal2002@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes