Migrate ScoreCard.test.js from Enzyme to React Shallow Renderer #1653
Conversation
Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
|
please address comments in #1643 |
|
@yurishkuro About the @testing-library/react @testing-library/jest-dom deps, they don't need to be installed for the scope of this PR, but as we are using two functions from Enzyme, |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1653 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 241 241
Lines 7558 7558
Branches 1984 1984
=======================================
Hits 7257 7257
Misses 301 301 ☔ View full report in Codecov by Sentry. |
|
@yurishkuro Could you please also check this one. |
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| // SOFTWARE. |
There was a problem hiding this comment.
my bad, I should've used formatted versions, just pushed an update
| @@ -0,0 +1,102 @@ | |||
| // Copyright (c) 2023 The Jaeger Authors | |||
| // Adopted from https://thesametech.com/snapshot-testing-in-rtl/ | |||
| // Copyright (c) 2023 Ildar Sharafeev | |||
There was a problem hiding this comment.
Author's permission in this comment: #1653 (comment)
Signed-off-by: Yuri Shkuro <github@ysh.us>
|
Nice job! |
Which problem is this PR solving?
ScoreCard.test.jsfrom Enzyme to React Testing LibraryDescription of the changes
How was this change tested?
yarn test -- -uto re-generate snapshots of the changed testsyarn test-ci ScoreCard.test.js --coveragewas used to check if all tests pass and coverage is 100%Checklist