Recognize uninstrumented services via both producer and client span kinds
#1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wck-iipi <21dcs006@nith.ac.in>
|
@yurishkuro DCO check passes and test case is now done with the help of an array. |
yurishkuro
approved these changes
Aug 14, 2023
yurishkuro
changed the title
producer and client span kinds
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1681 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 241 241
Lines 7558 7560 +2
Branches 1984 1985 +1
=======================================
+ Hits 7257 7259 +2
Misses 301 301
☔ View full report in Codecov by Sentry. |
anshgoyalevil
pushed a commit
to anshgoyalevil/jaeger-ui
that referenced
this pull request
Aug 16, 2023
…an kinds (jaegertracing#1681) ## Which problem is this PR solving? Resolves jaegertracing#660 ## Description of the changes VirtualizedTraceView now checks if kind is producer. ## How was this change tested? I changed HotROD MySQL kind to producer and then tested it. ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test`  Signed-off-by: wck-iipi <21dcs006@nith.ac.in> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #660
Description of the changes
VirtualizedTraceView now checks if kind is producer.
How was this change tested?
I changed HotROD MySQL kind to producer and then tested it.
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test