-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] Remove enzyme from QualityMetrics tests #1684
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a12cdf7
migrating from Enzym to RTL
Freedisch 751f6f9
updated tests
f760b9d
revert migration into snapshots
74c2c7e
refactor shallow
9034cef
rm comments
52364d0
Merge branch 'main' into migration
Freedisch 92bae04
update tests
Freedisch ccc7d43
snapshots update
Freedisch f370b16
fix
Freedisch f3be9d9
Merge branch 'main' into migration
Freedisch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,32 +13,35 @@ | |
// limitations under the License. | ||
|
||
import React from 'react'; | ||
import { shallow } from 'enzyme'; | ||
|
||
import { render, screen } from '@testing-library/react'; | ||
import '@testing-library/jest-dom/'; | ||
import BannerText from './BannerText'; | ||
|
||
describe('BannerText', () => { | ||
it('renders null when props.bannerText is falsy', () => { | ||
expect(shallow(<BannerText />).type()).toBe(null); | ||
const { container } = render(<BannerText />); | ||
expect(container.firstChild).toBe(null); | ||
}); | ||
|
||
it('renders header when props.bannerText is a string', () => { | ||
expect(shallow(<BannerText bannerText="foo text" />)).toMatchSnapshot(); | ||
render(<BannerText bannerText="foo text" />); | ||
expect(screen.getByText('foo text')).toBeInTheDocument(); | ||
}); | ||
|
||
it('renders styled header when props.bannerText is a styled value', () => { | ||
expect( | ||
shallow( | ||
<BannerText | ||
bannerText={{ | ||
styling: { | ||
background: 'red', | ||
color: 'white', | ||
}, | ||
value: 'foo text', | ||
}} | ||
/> | ||
) | ||
).toMatchSnapshot(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Snapshots need to be purged for this too. Otherwise, the tests would pass, but CI will fail. |
||
render( | ||
<BannerText | ||
bannerText={{ | ||
styling: { | ||
background: 'red', | ||
color: 'white', | ||
}, | ||
value: 'foo text', | ||
}} | ||
/> | ||
); | ||
|
||
expect(screen.getByText('foo text')).toBeInTheDocument(); | ||
expect(screen.getByText('foo text')).toHaveStyle('background: red; color: white;'); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 0 additions & 23 deletions
23
packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/BannerText.test.js.snap
This file was deleted.
Oops, something went wrong.
46 changes: 0 additions & 46 deletions
46
packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/CountCard.test.js.snap
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
toMatchSnapshot()
is no longer used, the snapshots created for this test needs to be purged.You can use the command
yarn test --updateSnapshot
for that.