Moment.js replaced with Dayjs #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prathamesh-mutkure
requested review from
everett980 and
rubenvp8510
as code owners
Codecov ReportPatch coverage is 📢 Thoughts on this report? Let us know!. |
yurishkuro
reviewed
Aug 28, 2023
packages/jaeger-ui/src/components/SearchTracePage/SearchForm.test.js
Outdated
Show resolved
Hide resolved
packages/jaeger-ui/src/components/SearchTracePage/SearchResults/ResultItem.tsx
Outdated
Show resolved
Hide resolved
|
I was on antd migration guide from v3 to v4 and I noticed, they provided a guide to migrate from moment to dayjs. Have you used it to achieve this ? |
Hi @mmorel-35, the guide you mentioned is specifically for Ant Design component, this is not specific to moment to dayjs guide and thus not relevant to our scenario |
|
I forgot to add more unit tests, let me do it real quick |
yurishkuro
reviewed
Aug 29, 2023
|
@prathamesh-mutkure please add missing tests to have patch coverage 100% |
prathamesh-mutkure
force-pushed
the
dayjs-migration
branch
2 times, most recently
from
c1af184
to
2a71e75
Compare
|
Can you rebase your changes with the latest main branch? |
prathamesh-mutkure
force-pushed
the
dayjs-migration
branch
from
7cbdced
to
5f76300
Compare
yurishkuro
reviewed
Sep 18, 2023
prathamesh-mutkure
force-pushed
the
dayjs-migration
branch
2 times, most recently
from
1b75383
to
1095a96
Compare
4 tasks
Signed-off-by: Prathamesh Mutkure <pmutkure009@gmail.com>
Signed-off-by: Prathamesh Mutkure <pmutkure009@gmail.com>
Signed-off-by: Prathamesh Mutkure <pmutkure009@gmail.com>
Signed-off-by: Prathamesh Mutkure <pmutkure009@gmail.com>
Signed-off-by: Prathamesh Mutkure <pmutkure009@gmail.com>
Signed-off-by: Prathamesh Mutkure <pmutkure009@gmail.com>
Signed-off-by: Prathamesh Mutkure <pmutkure009@gmail.com>
Signed-off-by: Prathamesh Mutkure <pmutkure009@gmail.com>
Signed-off-by: Prathamesh Mutkure <pmutkure009@gmail.com>
Signed-off-by: Prathamesh Mutkure <pmutkure009@gmail.com>
Signed-off-by: Prathamesh Mutkure <pmutkure009@gmail.com>
prathamesh-mutkure
force-pushed
the
dayjs-migration
branch
from
9c33052
to
492e9aa
Compare
yurishkuro
added a commit
that referenced
this pull request
Sep 22, 2023
## Which problem is this PR solving? - Bunch of new constants are added as exported in #1738, even though they are not used anywhere in the code ## Description of the changes - Remove `export` ## How was this change tested? - CI --------- Signed-off-by: Yuri Shkuro <github@ysh.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
moment.jsand replaced it withdayjspackagesHow was this change tested?
Monitortab,SpanandTraceview,Searchpage, all the charts, etc.The UI was checked between
jaeger-all-in-oneand changes of this commitChecklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test