Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CopyIcon to receive ReactNode instead of string #1791

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

anshgoyalevil
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Since ant-design v4 doesn't support Icon Names passed to the Button Prop as a string. Instead, it needs a React Node to be passed.

How was this change tested?

  • yarn test

New Behavior:

image
image

Previous Behavior:

image

Checklist

Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
@codecov
Copy link

codecov bot commented Sep 15, 2023

@yurishkuro yurishkuro merged commit eaa0b9e into jaegertracing:main Sep 15, 2023
9 checks passed
@anshgoyalevil anshgoyalevil deleted the copyicon branch September 18, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: CopyIcon is not visible on SpanDetail Card
2 participants