Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up CI unit-test workflow by 28% #1804

Merged
merged 6 commits into from
Sep 18, 2023

Conversation

anshgoyalevil
Copy link
Contributor

Which problem is this PR solving?

  • I recently benchmarked against some jest settings to speed up the total test execution time.
  • The best setting according to GitHub Actions so far, according to internet and manual testing is using --maxWorkers=4

How was this change tested?

Checklist

Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@anshgoyalevil
Copy link
Contributor Author

This PR got its test suite executed in 3m 29 seconds 🪐

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW!

@yurishkuro yurishkuro merged commit 3ff2041 into jaegertracing:main Sep 18, 2023
9 checks passed
@yurishkuro
Copy link
Member

Q: when running test locally we use yarn test, which is different from test-ci. Is there also a possibility to increase its performance?

@anshgoyalevil
Copy link
Contributor Author

Yes. There is, but it is yet to be tested manually. Some posts suggest having --maxWorkers=50% as the setting for local test scripts.
Would try this out with multiple options to find out the best combination.

@anshgoyalevil anshgoyalevil deleted the jest-boost branch September 22, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants