Add Custom withRouteProps HOC for react-router-dom v6 migration #1836
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
withRouteProps
HOC since rrd v6 doesn't supportwithRouter
.useHistory()
hook and provider to use thehistory
object in our customwithRouterProps
HOC.Why this PR is necessary?
withRouter
removal in rrd v6, this PR ensure that we migrate out codebase at v5 only as recommended by the react-router-dom team in their v5 to v6 migration guideHow was this change tested?
screen-capture.3.webm
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test