Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated visible prop of ant-design v3 with open prop of ant-design v4 #1855

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

anshgoyalevil
Copy link
Member

@anshgoyalevil anshgoyalevil commented Oct 9, 2023

Which problem is this PR solving?

Description of the changes

  • This PR replaces the deprecated visible prop of ant-design v3 with open prop of ant-design v4
  • These props are exactly the same, just the name differs.

How was this change tested?

  • unit tests, and manually

Checklist

Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...ents/TraceDiff/TraceDiffHeader/TraceDiffHeader.tsx 100.00% <ø> (ø)
...racePage/TracePageHeader/KeyboardShortcutsHelp.tsx 100.00% <ø> (ø)
...kages/jaeger-ui/src/components/common/CopyIcon.tsx 100.00% <ø> (ø)
...s/jaeger-ui/src/utils/redux-form-field-adapter.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@anshgoyalevil anshgoyalevil changed the title replace deprecated visible prop of ant-design v3 with open prop of ant-design v4 Replace deprecated visible prop of ant-design v3 with open prop of ant-design v4 Oct 9, 2023
@anshgoyalevil
Copy link
Member Author

anshgoyalevil commented Oct 9, 2023

@yurishkuro Shouldn't we use something like asyncapi/website#2170 (comment)
A check that fails the CI if the PR's title is not properly linted according to Conventional Commits specification.

Though, I know, a similar issue is being worked upon inside the jaeger repo for organizing PRs in changelog according to tags, but this would help too.

Plus a badge, that we can show off. Conventional Commits

@yurishkuro
Copy link
Member

Shouldn't we use something like asyncapi/website#2170 (comment)

yep, that's the idea behind #4799. I like the list published by that bot.

@yurishkuro yurishkuro merged commit 797e0d8 into jaegertracing:main Oct 9, 2023
9 checks passed
@anshgoyalevil anshgoyalevil deleted the 3antd branch October 10, 2023 04:10
@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants