Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated usage of ant-design Tabs component from SearchTracePage #1857

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

anshgoyalevil
Copy link
Member

@anshgoyalevil anshgoyalevil commented Oct 9, 2023

Which problem is this PR solving?

Description of the changes

  • replace deprecated usage of Tabs component from SearchTracePage
  • The ant-design v4 introduces a new API items which increases the performance by deferring the In-Active components for the first load.
  • This is the reason we cannot test for the actual FileLoader component to be present, rather, we can test for the Tab Key to be present.

How was this change tested?

  • manually, and automated tests

Checklist

Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...jaeger-ui/src/components/SearchTracePage/index.jsx 90.90% <100.00%> (+2.40%) ⬆️

📢 Thoughts on this report? Let us know!.

Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
@yurishkuro yurishkuro changed the title replace deprecated usage of ant-design Tabs component from SearchTracePage Replace deprecated usage of ant-design Tabs component from SearchTracePage Oct 9, 2023
@yurishkuro yurishkuro merged commit b89bc46 into jaegertracing:main Oct 9, 2023
9 checks passed
@anshgoyalevil anshgoyalevil deleted the 4antd branch October 10, 2023 04:10
@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants