Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Style for IoArrowForward #1869

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

NineKama
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Add vertical-align: middle to align arrow with circle

How was this change tested?

  • Manually

image

Checklist

Signed-off-by: Dat Diep <luccymoon@gmail.com>
@NineKama NineKama changed the title Arrowforward Add Style for IoArrowForward Oct 13, 2023
yurishkuro
yurishkuro previously approved these changes Oct 13, 2023
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yurishkuro yurishkuro enabled auto-merge (squash) October 13, 2023 15:32
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...nents/TracePage/TraceTimelineViewer/SpanBarRow.tsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Signed-off-by: Dat Diep <luccymoon@gmail.com>
auto-merge was automatically disabled October 13, 2023 15:47

Head branch was pushed to by a user without write access

@NineKama
Copy link
Contributor Author

@yurishkuro can you help me to re-approve it, forgot prettier

@yurishkuro yurishkuro changed the title Add Style for IoArrowForward fix: Add Style for IoArrowForward Oct 13, 2023
@yurishkuro yurishkuro merged commit 87e6e6f into jaegertracing:main Oct 13, 2023
8 of 10 checks passed
@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Poor choice of right-arrow icon
2 participants