Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add the label-check workflow to verify changelog labels on each PR #1897

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

anshgoyalevil
Copy link
Contributor

@anshgoyalevil anshgoyalevil commented Oct 21, 2023

Which problem is this PR solving?

Description of the changes

  • Add a GitHub Action that will verify that a PR has a specific categorization label before it can be merged. We already have a bunch of those labels changelog:*** labels
  • Configure dependabot to use changelog:dependencies label
  • Since we already use the release script from jaeger repo, everything else is setup 🚀
  • One task is left, that is to create changelog labels inside this jaeger-ui repository. //cc: @yurishkuro

jaeger-ui/Makefile

Lines 2 to 5 in 1909398

changelog:
wget https://raw.githubusercontent.com/jaegertracing/jaeger/main/scripts/release-notes.py -O ./scripts/release-notes.py -q
chmod 755 ./scripts/release-notes.py
./scripts/release-notes.py --exclude-dependabot --repo jaeger-ui

How was this change tested?

Checklist

Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
@anshgoyalevil anshgoyalevil requested a review from a team as a code owner October 21, 2023 04:19
@anshgoyalevil anshgoyalevil requested review from yurishkuro and removed request for a team October 21, 2023 04:19
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Oct 21, 2023
@yurishkuro yurishkuro merged commit b45465d into jaegertracing:main Oct 21, 2023
10 of 11 checks passed
@yurishkuro
Copy link
Member

Thanks!

@anshgoyalevil anshgoyalevil deleted the lb-check branch October 23, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: (Re)Introduce changelog-related labels and require them for PRs
2 participants