Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tooltip when hovered on header column of TraceStatistics view #1902

Merged
merged 6 commits into from
Oct 22, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -41,59 +41,69 @@ type State = {

const columnsArray: any[] = [
{
title: 'Name',
title: 'Group',
attribute: 'name',
suffix: '',
},
{
title: 'Count',
attribute: 'count',
suffix: '',
titleDescription: 'Number of spans',
},
{
title: 'Total',
attribute: 'total',
suffix: 'ms',
titleDescription: 'Total duration of all spans',
},
{
title: 'Avg',
attribute: 'avg',
suffix: 'ms',
titleDescription: 'Average duration of all spans',
},
{
title: 'Min',
attribute: 'min',
suffix: 'ms',
titleDescription: 'Minimum duration across all spans',
},
{
title: 'Max',
attribute: 'max',
suffix: 'ms',
titleDescription: 'Maximum duration across all spans',
},
{
title: 'ST Total',
attribute: 'selfTotal',
suffix: 'ms',
titleDescription: 'Sum of Self Time (time spent in a span when it was not waiting on children)',
},
{
title: 'ST Avg',
attribute: 'selfAvg',
suffix: 'ms',
titleDescription: 'Average Self Time (time spent in a span when it was not waiting on children)',
},
{
title: 'ST Min',
attribute: 'selfMin',
suffix: 'ms',
titleDescription: 'Minimum Self Time (time spent in a span when it was not waiting on children)',
},
{
title: 'ST Max',
attribute: 'selfMax',
suffix: 'ms',
titleDescription: 'Maximum Self Time (time spent in a span when it was not waiting on children)',
},
{
title: 'ST in Duration',
attribute: 'percent',
suffix: '%',
titleDescription: 'Percentage of ST Total vs. Total',
},
];

Expand Down Expand Up @@ -301,6 +311,7 @@ export default class TraceStatistics extends Component<Props, State> {
sorter: sorterFunction(val.attribute),
render: renderFunction,
onCell: onCellFunction,
showSorterTooltip: val.attribute !== 'name' ? { title: val.titleDescription } : false,
};
return val.attribute === 'count' ? { ...ele, defaultSortOrder: 'ascend' } : ele;
});
Expand Down
Loading