Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Error stored in redux trace.traces #195

Merged
merged 2 commits into from Mar 13, 2018
Merged

Handle Error stored in redux trace.traces #195

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f79140
Fix 166 - Handle Error objs in redux trace.traces
tiffon Mar 12, 2018
bafe9a6
Filter for Error objs one level higher
tiffon Mar 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/model/search.js
View file
Open in desktop
Expand Up @@ -79,11 +79,18 @@ export function getTraceSummary(trace: Trace): TraceSummary {
/**
* Transforms `Trace` values into `TraceSummary` values and finds the max duration of the traces.
*
* @param {Trace} _traces The trace data in the format from the HTTP request.
* @param {(Trace | Error)[]} _traces The trace data in the format from the HTTP request.
* @return {TraceSummaries} The `{ traces, maxDuration }` value.
*/
export function getTraceSummaries(_traces: Trace[]): TraceSummaries {
const traces = _traces.map(getTraceSummary);
export function getTraceSummaries(_traces: (Trace | Error)[]): TraceSummaries {
const traces = _traces
.map(item => {
if (item instanceof Error) {
return null;
}
return getTraceSummary(item);
})
.filter(Boolean);
const maxDuration = Math.max(..._map(traces, 'duration'));
return { maxDuration, traces };
}
Expand Down