Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate TraceDiffs/Header from enzyme to RTL #1962

Merged
merged 7 commits into from
Nov 12, 2023

Commits on Nov 11, 2023

  1. Migrate ChevronDown from enzyme to RTL (jaegertracing#1961)

    ## Which problem is this PR solving?
    Fixes part of jaegertracing#1668
    
    ## Description of the changes
    Migrates the test for `ChevronDown.tsx` to RTL
    
    ## How was this change tested?
    Ran the test suite locally
    
    ## Checklist
    - [X] I have read
    https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
    - [X] I have signed all commits
    - [X] I have added unit tests for the new functionality
    - [X] I have run lint and test steps successfully
      - for `jaeger`: `make lint test`
      - for `jaeger-ui`: `yarn lint` and `yarn test`
    
    Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>
    EshaanAgg committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    9d14f28 View commit details
    Browse the repository at this point in the history
  2. refac: migrate TraceHeader from enzyme to RTL

    Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>
    EshaanAgg committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    a3abd00 View commit details
    Browse the repository at this point in the history
  3. refac: remove the nesting of TraceHeader

    Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>
    EshaanAgg committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    8446e73 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0b0b906 View commit details
    Browse the repository at this point in the history
  5. fix: Add explicit checks for traceAttr in tests

    Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>
    EshaanAgg committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    0ad9de7 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2023

  1. fix: update tests according to review

    Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>
    EshaanAgg committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    b816a1f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ff4a374 View commit details
    Browse the repository at this point in the history