Replace Reselect with Memoize #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove package Reselect Delete file selectors/dependencies Add the memoize function to components/DependencyGraph/index.tsx Signed-off-by: Muzi Qiu <qiumuzinaruto@gmail.com>
Signed-off-by: Muzi Qiu <qiumuzinaruto@gmail.com>
cooleditphoto
requested review from
joe-elliott
and removed request for
a team
yurishkuro
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2042 +/- ##
==========================================
- Coverage 96.55% 96.55% -0.01%
==========================================
Files 256 255 -1
Lines 7627 7625 -2
Branches 1983 1983
==========================================
- Hits 7364 7362 -2
Misses 263 263 ☔ View full report in Codecov by Sentry. |
yurishkuro
added
changelog:bugfix-or-minor-feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #2031
Description of the changes
Remove package Reselect
Delete file selectors/dependencies
Add the memoize function to components/DependencyGraph/index.tsx
How was this change tested?
yarn lint & yarn test
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test