Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use import from /dist/ instead of symlink #2135

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Use import from /dist/ instead of symlink #2135

merged 1 commit into from
Jan 26, 2024

Conversation

zacanger
Copy link
Contributor

@zacanger zacanger commented Jan 26, 2024

Which problem is this PR solving?

This is an insignificant issue, so I didn't open an issue ticket beforehand. There's a symlink here to a file in node_modules. It's small problem, but the symlink is unnecessary. I came across this because I have this repo as a submodule in another project, and back up those changes (and a lot of other repos) with rsync, the sync checks output to see if there are errors. I would guess this also causes problems on Windows without WSL.

Description of the changes

Change the import. This Just Works™ in Vite.

How was this change tested?

yarn lint && yarn test && yarn start, and yarn build, and grepping react-vis clases in the assets.

Screenshot 2024-01-26 at 11 10 46 Screenshot 2024-01-26 at 11 10 37

Checklist

Signed-off-by: Zac Anger <zac@zacanger.com>
@zacanger zacanger requested a review from a team as a code owner January 26, 2024 18:23
@zacanger zacanger requested review from albertteoh and removed request for a team January 26, 2024 18:23
@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Jan 26, 2024
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if importing from /dist/ is a good practice, but certainly not worse than the symlink

thanks

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (81bf7d7) 96.57% compared to head (1cc94b1) 96.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2135   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files         254      254           
  Lines        7620     7620           
  Branches     1986     1986           
=======================================
  Hits         7359     7359           
  Misses        261      261           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacanger
Copy link
Contributor Author

not sure if importing from /dist/ is a good practice, but certainly not worse than the symlink

thanks

It's definitely not, but that package doesn't specify a style in package.json (like this one).

@yurishkuro yurishkuro changed the title fix: broken symlink Use import from /dist/ instead of symlink Jan 26, 2024
@yurishkuro yurishkuro merged commit 60e5ce4 into jaegertracing:main Jan 26, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants