Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support uploading traces in OpenTelemetry format (OTLP JSON) #2145

Merged
merged 9 commits into from
Mar 4, 2024
Merged

Support uploading traces in OpenTelemetry format (OTLP JSON) #2145

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b99756d
Add middleware to accept OTLP traces when uploaded
NavinShrinivas Jan 30, 2024
ac50454
Adding unit test middleware
NavinShrinivas Jan 31, 2024
aaced54
Adding more tests and complying to CI/CD pipeline
NavinShrinivas Feb 7, 2024
9599ede
Merge branch 'main' into uploading_otlp_traces
yurishkuro Feb 7, 2024
f3827b0
Fixing error
NavinShrinivas Feb 13, 2024
eb689c2
Removing middleware and including API call as part of dispatch func
NavinShrinivas Feb 15, 2024
544bc25
Adding same test files as backend
NavinShrinivas Feb 15, 2024
2bd3a2f
Removing few useless imports
NavinShrinivas Feb 15, 2024
1e33ca7
Merge branch 'main' into uploading_otlp_traces
yurishkuro Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/jaeger-ui/src/middlewares/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export const loadJsonTracesMiddleware = store => next => action => {
} else {
return next(action);
}
return next(action); // Consistent returns
return undefined;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this the right behavior?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume calling the next action is a pattern that needs to be maintained, it looks like a dangerous shortcut when you change it just to work around another problem. The right fix is to control the order of these middlewares, so that OTLP translator is invoked before the rest of the handlers.

};

export const promise = promiseMiddleware;