Use JSON for table values only for objects

[bobrik]

Without this numbers are treated as json, which styles them with an offset:

With this change applied:

It's possible that there's a better solution for this.

Which problem is this PR solving?

https://github.com/jaegertracing/jaeger-ui/pull/1724/files#r1491924866

How was this change tested?

Manually tested.

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a150319) 96.57% compared to head (fba6b14) 96.57%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2168   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files         254      254           
  Lines        7620     7629    +9     
  Branches     1921     1925    +4     
=======================================
+ Hits         7359     7368    +9     
  Misses        261      261           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yurishkuro]

I actually like that it shows numbers differently

[bobrik]

I can understand the improvement from the numbers having a different color, but a random offset is not something you see in any software showing tables. It just looks broken to me.

[yurishkuro]

I think the way to fix the offset would be via changing the styling, not the business logic.

[bobrik]

The styling we apply to the table cell is based on the json-markup-child class, which is logically wrong, as the table cell is not a child of any json, because there is no json there to begin with:

The margin style is applied to the actual json children to provide the tree structure, so if you drop it, you're left with this:

Without my change numbers are nested into json-markup-number, while strings aren't, because they have their own condition branch that rightfully bypasses treating them as json.

[bobrik]

With the latest changes:

[yurishkuro]

Thanks!

[yurishkuro]

looks like the existing test cases are missing a case for boolean value, can you add it?

[bobrik]

Sure, added.

[yurishkuro]

🎉