Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ScatterPlot y-axis margin wider to fit longer durations #2211

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

tico88612
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Make ScatterPlot margin wider, 50 px => 70 px

How was this change tested?

  • manual test

Checklist

Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
@tico88612 tico88612 requested a review from a team as a code owner March 13, 2024 16:18
@tico88612 tico88612 requested review from joe-elliott and removed request for a team March 13, 2024 16:18
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.59%. Comparing base (3d9420a) to head (280920e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2211   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files         254      254           
  Lines        7641     7641           
  Branches     1927     1977   +50     
=======================================
  Hits         7381     7381           
  Misses        260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro changed the title Fix: ScatterPlot margin wider Make ScatterPlot y-axis margin wider to fit longer durations Mar 14, 2024
@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Mar 14, 2024
@yurishkuro yurishkuro merged commit 44babbb into jaegertracing:main Mar 14, 2024
8 of 9 checks passed
@yurishkuro
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Y-axis (duration) is not accurate for long-running traces
2 participants