Trace diffs #228

tiffon · 2018-07-24T17:03:16Z

Which problem is this PR solving?

Provides the ability to compare traces.

Short description of the changes

Enhances the plexus component and adds the ability to compare two traces to Jaeger UI.

The search page is changed to allow traces to be selected into a "diff cohort" and then compared.

A trace comparison page has been added which allows two traces from the "diff cohort" to be compared. Any two traces from the "diff cohort" can be compared. Traces are compared through the following process:

DenseTrace - Each trace is transformed into a "dense" tree structure, with some nodes skipped or ignored
- For more details on when and why nodes are skipped or ignored, see packages/jaeger-ui/src/model/trace-dag/denseTransforms.js
TraceDag - The trace in each tree is condensed further to a tree comprised of unique service/operation paths, with each node keeping track of the dense spans that are were collected into it
TraceDag as the diff - The two trees from the last step are compared, resulting in the another TraceDag tree, which is a union of the two input traces. In the new TraceDag, each node refers to the corresponding node created in step 2. Thus, the new nodes refer to the underlying nodes from each trace which themselves have references to the span data from the DenseTree.
When the diff is rendered, each node in the diff tree is shown in the UI, and each node is colored based on the number of spans the nodes represents from trace A and trace B.

The plexus graph component has been enhanced to have zoom and pan (optional), a mini-map (optional), and a number of changes have been made to the API to enable various performance optimizations.

Note: The above noted changes to the plexus component has not yet been release; the CI tests / builds will be back in order when the npm package is updated.

Side note: Regarding the size of this diff, Simon and I discussed three general strategies:

Break large efforts into smaller changesets and merge to a feature branch, then the overall feature can be merged to master. This will allow reviewing in reasonable chunks.
For some changes, significant portions are additive, like the trace-diff page in this portion, so breaking the diff into chunks where additive changes are separated from changes that are more invasive can help.
- For instance, four chunks for this diff:
  - plexus changes - This can be released to master
  - redux state changes
  - trace-diff page - This and above can be released to master
  - search page changes - This can be released to master
- This approach requires more planning and is not as accomadating to unknowns
The third strategy is greater modularity in the implementation. Pretty general, but always a good thing to keep in mind.

Screenshots

Search results

Search results with several selected traces

Search results scrolled

HotROD demo

Comparing two traces from the HotROD demo

In the screenshot above, the light green node indicates the second trace, B, has more spans on that path than trace A.

Mouseover effect shows the node at full zoom

The effect shown above is useful when large traces are being compared. In the case of large traces, it's common to zoom out quite a lot; the mouseover effect allows you lets you read the node.

Zoom in to full size

Zoom is more useful on larger traces.

Cohort selection

The dropdown to select which trace(s) to compare.

Excerpt of a larger trace

The screenshot above is an excerpt of a larger trace. The significance of the colors are:

Dark red - Trace B does not have spans on that path, but trace A does
Dark green - Trace B has spans on that path, but trace A does not
Light red - Trace B has fewer spans than trace A on that path
Light blue - Trace B has more spans that trace A on that path

tiffon · 2018-07-24T17:17:32Z

packages/plexus/src/DirectedGraph/MiniMap.js

+    const mapSize = getMapSize(this.props);
+    const activeXform = getViewTransform(this.props, mapSize);
+    return (
+      <div className={css.root}>


Note, this will not work nicely with stroke in some scenarios, perhaps make a note of that in a doc (which does not yet exist).

* Prep the repo for separately developed components * Fix uberinternal yarn.lock issues * Upgrade react to 16.3.2 * Update readme to account for on Lerna changes Signed-off-by: Joe Farro <joef@uber.com> Directed graph layout and presentation (#212) * Prep the repo for separately developed components Signed-off-by: Joe Farro <joef@uber.com> * WIP - Very rough graph layout functionality Signed-off-by: Joe Farro <joef@uber.com> * Graph layout functionality is in solid shape Outstanding: * tests * calculate edges via several workers when there are many edges Signed-off-by: Joe Farro <joef@uber.com> * Fix minor misc issues with plexus layout Signed-off-by: Joe Farro <joef@uber.com> * Fix uberinternal yarn.lock issues Signed-off-by: Joe Farro <joef@uber.com> * Fix uberinternal yarn.lock issues Signed-off-by: Joe Farro <joef@uber.com> * Upgrade react to 16.3.2 Signed-off-by: Joe Farro <joef@uber.com> * Upgrade flow to 0.71.0 Signed-off-by: Joe Farro <joef@uber.com> * Very rough React graph component Signed-off-by: Joe Farro <joef@uber.com> * Enable custom props for graph elements Signed-off-by: Joe Farro <joef@uber.com> * The graph refreshes when it gets new data Signed-off-by: Joe Farro <joef@uber.com> * Make the jaeger-ui package private Signed-off-by: Joe Farro <joef@uber.com> * Misc cleanup for plexus package.json Signed-off-by: Joe Farro <joef@uber.com> * Fix issues with plexus package.json Signed-off-by: Joe Farro <joef@uber.com> * Don't output a CSS file for plexus Signed-off-by: Joe Farro <joef@uber.com> * Increase plexus node spacing for neato layouts Signed-off-by: Joe Farro <joef@uber.com> * Update plexus to 0.0.1-dev.2 Signed-off-by: Joe Farro <joef@uber.com> * Adding new issue and pull request template (#219) Signed-off-by: Prakriti <prakritibansal98@gmail.com> * plexus readme, remove `LayoutManager.dispose()` Signed-off-by: Joe Farro <joef@uber.com> * remove unecessary package Signed-off-by: Joe Farro <joef@uber.com> * Add more complex graphs to plexus demo Signed-off-by: Joe Farro <joef@uber.com> * Start the worker ID at 0 Signed-off-by: Joe Farro <joef@uber.com> Search page functionality for trace diffs Signed-off-by: Joe Farro <joef@uber.com> Stub for trace diff page, update redux state shape - Better redux state shape for trace diff - Refer to traces selected for comparison as trace diff cohort - Better redux state shape for fetched trace data - Before: One loading prop to keep track of all search and individual trace fetching - After: Loading is tracked separately for serach and for each individual trace being fetched - This is better all around and lays the ground-work for fetching multiple individual traces which will be necessary for trace diff page when hit directly via URL (will need to fetch two or more traces) Signed-off-by: Joe Farro <joef@uber.com> Optimization for trace mini-map rendering On a trace with ~16k spans reduced minimap rendering from ~250ms to ~20ms. For context, the initial render of the trace was around 1.22s. Signed-off-by: Joe Farro <joef@uber.com> Redux cleanup, hydrate diff cohort on search page - Merge TraceSummary into Trace - Redux action to fetch multiple traces by ID - Create a small-sized variation of the loading indicator - SearchTracePage loads trace data for traces in the diff cohort - Show loading indicator when trace data is being loaded - Show inline error when trace loading fails - Strip failed traces from diff cohort when linking to diff page - Diff page forces redux state based on URL params Signed-off-by: Joe Farro <joef@uber.com> Trace diff page header functionality - Fetch traces that need to be loaded - Keep the URL and redux state in sync after changes to A or B - Allow entering traces by ID - Allow selecting other traces in the cohort - Indicate when loading a trace failed Signed-off-by: Joe Farro <joef@uber.com> Convert trace to a DAG Apply three transforms to spans when converting to DAG: - Adopt peer.service for service name when a client span is missing the corresponding server span - Ignore client spans when the only child is a reasonable server span - Try to figure out a better operation name when operation === the http.method tag The conversion can be optimized; it takes about 230ms on a trace with ~35k spans. A trace with ~9k spans takes about 50ms. Signed-off-by: Joe Farro <joef@uber.com> Add useDotEdges and totalMemory options to plexus - Option in plexus to set the totalMemory viz.js uses - Sometimes viz.js runs out of memory on large graphs, especially when using the neato engine, increasing the total memeory can help - Option in plexus to use dot edges in plexus graphs - Useful for trees (neato and plexus are very similar) or large graphs (neato is too slow) Signed-off-by: Joe Farro <joef@uber.com> Initial trace diff graph - Ability to create diff of two TraceDag instances - Additional transforms to trim superfluous nodes - skipAnnotationSpans - skipClientSpans Signed-off-by: Joe Farro <joef@uber.com> Add zoom and pan to plexus - Zoom and pan - Add graph state as param to setOn* props - Enable scaling edge stroke based on zoom level Signed-off-by: Joe Farro <joef@uber.com> Add zoom to trace diff and increase color contrast - Add zoom pan to trace diff - On node hover show node @ 1x zoom (useful when zoomed out) - Higher contrast colors for trace diff DAG - Allowing scrolling for errors - Fix issue with node sizing during measurement phase Signed-off-by: Joe Farro <joef@uber.com> Add a minimap to plexus to help zoom and pan Also added to trace-diffs Signed-off-by: Joe Farro <joef@uber.com> Guard plexus zoom functionality with a flag Signed-off-by: Joe Farro <joef@uber.com> Fixes and optimizations to plexus and trace diffs - Bug fix: Each graph should have a unique edge arrow def IRI - Keep strokes from scaling into invisibility when zooming - Remove redundant root node - Apply zoom transforms to the node and edge containers - Scale the arrow def based on the current zoom (when zoom is enabled) by scaling the coords in the marker and path definitions - Add a convenience prop-factory that toggles a class, "is-small", based on the current zoom level - Use "is-small" to toggle the visibility of node text and edge stroke width based on the current zoom level - Change prop factories to be grouped by feature instead of context - In many cases the prop factory can be applied to multiple contexts, e.g. to both the edges container and an edge path - Make Node and EdgePath components PureComponents - Wrap rendering the nodes and edges in a PureComponent to prevent unnecessary renders - Remove DirectedGraphState from the edge and node factory prop functions to prevent rendering with every transform change Signed-off-by: Joe Farro <joef@uber.com> Add additional layout options to plexus Signed-off-by: Joe Farro <joef@uber.com> Lighten trace diff color scheme Signed-off-by: Joe Farro <joef@uber.com> Use green instead of blue in trace diff coloring Green is more commonly used to show additions Signed-off-by: Joe Farro <joef@uber.com> Add "Compare" to the top nav and other small fixes Signed-off-by: Joe Farro <joef@uber.com> Adding new issue and pull request template (#219) Signed-off-by: Prakriti <prakritibansal98@gmail.com> Integrate Google Analytics into Search Page (#220) * Integrate GA into search page Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Review changes Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Remove tracking of actual values Signed-off-by: Davit Yeghshatyan <davo@uber.com> Timeline Expand and Collapse Features (#221) * Add expansion and collapsing features Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Use Icon component Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Use spans upstream Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Improve css Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Rotate collapse buttons Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Remove debug logging Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Remove spans from TimelineHeaderRow Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Add unit test for TimelineCollapser Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Use popover Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Add TimelineCollapser test Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Revert "Use popover" This reverts commit 6152402 Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Add tests for duck.js Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Add more tests for duck.js Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Add more tests for index.js Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Add keyboard shortcuts Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Update changelog Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Make review changes Signed-off-by: Davit Yeghshatyan <davo@uber.com> Squashed commits from develop-directed-graph (#224) Signed-off-by: Joe Farro <joef@uber.com> Lazily initialize the first worker in plexus Signed-off-by: Joe Farro <joef@uber.com> Fix issue with trace diff URL from auth redirects The trace diff url was of the form: /trace/<trace-a-id>:diff?b=<trace-b-id> But, during OneLogin / SAML auth redirects it would get URL encoded and then not URL decoded resulting in it being interpreted as a trace ID. Move to the following form with three literal periods between the IDs: /trace/<trace-a-id>...<trace-b-id> Other misc fixes and tweaks: - Fix an issue where selecting a cohort of traces and then clicking the "Compare" button in the top nav cleared the cohort - Fix an issue where removing a trace from the cohort on the search page would not clear the trace from A or B, effectively preventing traces set as A or B from ever being removed - Clean up route definitions Signed-off-by: Joe Farro <joef@uber.com> Fix trace detail tracking for revised redux shape Signed-off-by: Joe Farro <joef@uber.com>

Signed-off-by: Joe Farro <joef@uber.com>

tiffon · 2018-08-06T20:41:59Z

@simonrobb Can you look this diff over, when you get the chance?

tiffon · 2018-08-06T20:52:12Z

@yurishkuro Can you look over the license compliance issue? It requires maintainer access.

Also tweak the demo a bit. Signed-off-by: Joe Farro <joef@uber.com>

simonrobb

Really great work 👍

simonrobb · 2018-08-08T16:53:17Z

packages/jaeger-ui/src/components/App/Page.js

 }

+// export default withRouter(connect(mapStateToProps)(PageImpl));


simonrobb · 2018-08-09T18:30:56Z

packages/jaeger-ui/src/components/SearchTracePage/SearchResults/ResultItem.test.js

-  expect(numberOfSpanText).toBe('5 Spans');
-  expect(numberOfServicesTags).toBe(1);
+  expect(numberOfSpanText).toBe(`${trace.spans.length} Spans`);
+  expect(numberOfServicesTags).toBe(trace.services.length);


I find toHaveLength to be more intuitive for measuring the length of collections

simonrobb · 2018-08-09T18:55:01Z

packages/jaeger-ui/src/components/SearchTracePage/SearchResults/index.js

+          <div className="u-simple-card" data-test={markers.NO_RESULTS}>
+            No trace results. Try another query.
+          </div>
+        </React.Fragment>


Can you remove the block conditionals here?

return ( <React.Fragment> {diffCohort.length > 0 && diffSelection} {!skipMessage && <div className="u-simple-card" data-test={markers.NO_RESULTS}> No trace results. Try another query. </div>} </React.Fragment> );

simonrobb · 2018-08-09T19:01:15Z

packages/jaeger-ui/src/components/SearchTracePage/index.test.js

+    const { maxTraceDuration, traceResults, diffCohort, numberOfTraceResults, ...rest } = mapStateToProps(
+      state
+    );
+    expect(traceResults.length).toBe(stateTrace.search.results.length);


toHaveLength?

tiffon

@simonrobb Awesome, thank you!

Signed-off-by: Joe Farro <joef@uber.com>

codecov · 2018-08-13T05:30:46Z

Codecov Report

Merging #228 into master will decrease coverage by 11.4%.
The diff coverage is 31.46%.

@@             Coverage Diff             @@
##           master     #228       +/-   ##
===========================================
- Coverage   90.05%   78.64%   -11.41%     
===========================================
  Files         109      135       +26     
  Lines        2464     2927      +463     
  Branches      505      607      +102     
===========================================
+ Hits         2219     2302       +83     
- Misses        207      494      +287     
- Partials       38      131       +93

Impacted Files	Coverage Δ
.../jaeger-ui/src/components/DependencyGraph/index.js	`100% <ø> (ø)`	⬆️
packages/jaeger-ui/src/model/span.js	`100% <ø> (ø)`	⬆️
...Page/TraceTimelineViewer/SpanDetail/DetailState.js	`94.44% <ø> (ø)`	⬆️
.../TracePage/TraceTimelineViewer/SpanDetail/index.js	`100% <ø> (ø)`	⬆️
...ger-ui/src/components/TracePage/SpanGraph/index.js	`76.92% <ø> (ø)`	⬆️
packages/jaeger-ui/src/utils/configure-store.js	`100% <ø> (ø)`	⬆️
...ge/TraceTimelineViewer/SpanDetail/AccordianLogs.js	`100% <ø> (ø)`	⬆️
packages/jaeger-ui/src/components/App/index.js	`100% <ø> (ø)`	⬆️
...aceTimelineViewer/SpanDetail/AccordianKeyValues.js	`100% <ø> (ø)`	⬆️
packages/jaeger-ui/src/model/link-patterns.js	`92.85% <ø> (ø)`	⬆️
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 045524a...ee39701. Read the comment docs.

Signed-off-by: Joe Farro <joef@uber.com>

* Use Lerna (jaegertracing#209) * Prep the repo for separately developed components * Fix uberinternal yarn.lock issues * Upgrade react to 16.3.2 * Update readme to account for on Lerna changes Signed-off-by: Joe Farro <joef@uber.com> Directed graph layout and presentation (jaegertracing#212) * Prep the repo for separately developed components Signed-off-by: Joe Farro <joef@uber.com> * WIP - Very rough graph layout functionality Signed-off-by: Joe Farro <joef@uber.com> * Graph layout functionality is in solid shape Outstanding: * tests * calculate edges via several workers when there are many edges Signed-off-by: Joe Farro <joef@uber.com> * Fix minor misc issues with plexus layout Signed-off-by: Joe Farro <joef@uber.com> * Fix uberinternal yarn.lock issues Signed-off-by: Joe Farro <joef@uber.com> * Fix uberinternal yarn.lock issues Signed-off-by: Joe Farro <joef@uber.com> * Upgrade react to 16.3.2 Signed-off-by: Joe Farro <joef@uber.com> * Upgrade flow to 0.71.0 Signed-off-by: Joe Farro <joef@uber.com> * Very rough React graph component Signed-off-by: Joe Farro <joef@uber.com> * Enable custom props for graph elements Signed-off-by: Joe Farro <joef@uber.com> * The graph refreshes when it gets new data Signed-off-by: Joe Farro <joef@uber.com> * Make the jaeger-ui package private Signed-off-by: Joe Farro <joef@uber.com> * Misc cleanup for plexus package.json Signed-off-by: Joe Farro <joef@uber.com> * Fix issues with plexus package.json Signed-off-by: Joe Farro <joef@uber.com> * Don't output a CSS file for plexus Signed-off-by: Joe Farro <joef@uber.com> * Increase plexus node spacing for neato layouts Signed-off-by: Joe Farro <joef@uber.com> * Update plexus to 0.0.1-dev.2 Signed-off-by: Joe Farro <joef@uber.com> * Adding new issue and pull request template (jaegertracing#219) Signed-off-by: Prakriti <prakritibansal98@gmail.com> * plexus readme, remove `LayoutManager.dispose()` Signed-off-by: Joe Farro <joef@uber.com> * remove unecessary package Signed-off-by: Joe Farro <joef@uber.com> * Add more complex graphs to plexus demo Signed-off-by: Joe Farro <joef@uber.com> * Start the worker ID at 0 Signed-off-by: Joe Farro <joef@uber.com> Search page functionality for trace diffs Signed-off-by: Joe Farro <joef@uber.com> Stub for trace diff page, update redux state shape - Better redux state shape for trace diff - Refer to traces selected for comparison as trace diff cohort - Better redux state shape for fetched trace data - Before: One loading prop to keep track of all search and individual trace fetching - After: Loading is tracked separately for serach and for each individual trace being fetched - This is better all around and lays the ground-work for fetching multiple individual traces which will be necessary for trace diff page when hit directly via URL (will need to fetch two or more traces) Signed-off-by: Joe Farro <joef@uber.com> Optimization for trace mini-map rendering On a trace with ~16k spans reduced minimap rendering from ~250ms to ~20ms. For context, the initial render of the trace was around 1.22s. Signed-off-by: Joe Farro <joef@uber.com> Redux cleanup, hydrate diff cohort on search page - Merge TraceSummary into Trace - Redux action to fetch multiple traces by ID - Create a small-sized variation of the loading indicator - SearchTracePage loads trace data for traces in the diff cohort - Show loading indicator when trace data is being loaded - Show inline error when trace loading fails - Strip failed traces from diff cohort when linking to diff page - Diff page forces redux state based on URL params Signed-off-by: Joe Farro <joef@uber.com> Trace diff page header functionality - Fetch traces that need to be loaded - Keep the URL and redux state in sync after changes to A or B - Allow entering traces by ID - Allow selecting other traces in the cohort - Indicate when loading a trace failed Signed-off-by: Joe Farro <joef@uber.com> Convert trace to a DAG Apply three transforms to spans when converting to DAG: - Adopt peer.service for service name when a client span is missing the corresponding server span - Ignore client spans when the only child is a reasonable server span - Try to figure out a better operation name when operation === the http.method tag The conversion can be optimized; it takes about 230ms on a trace with ~35k spans. A trace with ~9k spans takes about 50ms. Signed-off-by: Joe Farro <joef@uber.com> Add useDotEdges and totalMemory options to plexus - Option in plexus to set the totalMemory viz.js uses - Sometimes viz.js runs out of memory on large graphs, especially when using the neato engine, increasing the total memeory can help - Option in plexus to use dot edges in plexus graphs - Useful for trees (neato and plexus are very similar) or large graphs (neato is too slow) Signed-off-by: Joe Farro <joef@uber.com> Initial trace diff graph - Ability to create diff of two TraceDag instances - Additional transforms to trim superfluous nodes - skipAnnotationSpans - skipClientSpans Signed-off-by: Joe Farro <joef@uber.com> Add zoom and pan to plexus - Zoom and pan - Add graph state as param to setOn* props - Enable scaling edge stroke based on zoom level Signed-off-by: Joe Farro <joef@uber.com> Add zoom to trace diff and increase color contrast - Add zoom pan to trace diff - On node hover show node @ 1x zoom (useful when zoomed out) - Higher contrast colors for trace diff DAG - Allowing scrolling for errors - Fix issue with node sizing during measurement phase Signed-off-by: Joe Farro <joef@uber.com> Add a minimap to plexus to help zoom and pan Also added to trace-diffs Signed-off-by: Joe Farro <joef@uber.com> Guard plexus zoom functionality with a flag Signed-off-by: Joe Farro <joef@uber.com> Fixes and optimizations to plexus and trace diffs - Bug fix: Each graph should have a unique edge arrow def IRI - Keep strokes from scaling into invisibility when zooming - Remove redundant root node - Apply zoom transforms to the node and edge containers - Scale the arrow def based on the current zoom (when zoom is enabled) by scaling the coords in the marker and path definitions - Add a convenience prop-factory that toggles a class, "is-small", based on the current zoom level - Use "is-small" to toggle the visibility of node text and edge stroke width based on the current zoom level - Change prop factories to be grouped by feature instead of context - In many cases the prop factory can be applied to multiple contexts, e.g. to both the edges container and an edge path - Make Node and EdgePath components PureComponents - Wrap rendering the nodes and edges in a PureComponent to prevent unnecessary renders - Remove DirectedGraphState from the edge and node factory prop functions to prevent rendering with every transform change Signed-off-by: Joe Farro <joef@uber.com> Add additional layout options to plexus Signed-off-by: Joe Farro <joef@uber.com> Lighten trace diff color scheme Signed-off-by: Joe Farro <joef@uber.com> Use green instead of blue in trace diff coloring Green is more commonly used to show additions Signed-off-by: Joe Farro <joef@uber.com> Add "Compare" to the top nav and other small fixes Signed-off-by: Joe Farro <joef@uber.com> Adding new issue and pull request template (jaegertracing#219) Signed-off-by: Prakriti <prakritibansal98@gmail.com> Integrate Google Analytics into Search Page (jaegertracing#220) * Integrate GA into search page Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Review changes Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Remove tracking of actual values Signed-off-by: Davit Yeghshatyan <davo@uber.com> Timeline Expand and Collapse Features (jaegertracing#221) * Add expansion and collapsing features Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Use Icon component Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Use spans upstream Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Improve css Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Rotate collapse buttons Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Remove debug logging Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Remove spans from TimelineHeaderRow Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Add unit test for TimelineCollapser Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Use popover Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Add TimelineCollapser test Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Revert "Use popover" This reverts commit 6152402 Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Add tests for duck.js Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Add more tests for duck.js Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Add more tests for index.js Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Add keyboard shortcuts Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Update changelog Signed-off-by: Davit Yeghshatyan <davo@uber.com> * Make review changes Signed-off-by: Davit Yeghshatyan <davo@uber.com> Squashed commits from develop-directed-graph (jaegertracing#224) Signed-off-by: Joe Farro <joef@uber.com> Lazily initialize the first worker in plexus Signed-off-by: Joe Farro <joef@uber.com> Fix issue with trace diff URL from auth redirects The trace diff url was of the form: /trace/<trace-a-id>:diff?b=<trace-b-id> But, during OneLogin / SAML auth redirects it would get URL encoded and then not URL decoded resulting in it being interpreted as a trace ID. Move to the following form with three literal periods between the IDs: /trace/<trace-a-id>...<trace-b-id> Other misc fixes and tweaks: - Fix an issue where selecting a cohort of traces and then clicking the "Compare" button in the top nav cleared the cohort - Fix an issue where removing a trace from the cohort on the search page would not clear the trace from A or B, effectively preventing traces set as A or B from ever being removed - Clean up route definitions Signed-off-by: Joe Farro <joef@uber.com> Fix trace detail tracking for revised redux shape Signed-off-by: Joe Farro <joef@uber.com> * Typo Signed-off-by: Joe Farro <joef@uber.com> * Fix jaegertracing#232 Split leaf from parent nodes in the tree Signed-off-by: Joe Farro <joef@uber.com> * plexus - Fix chart style issues and bump version Also tweak the demo a bit. Signed-off-by: Joe Farro <joef@uber.com> * Fix yarn workspace based install Signed-off-by: Joe Farro <joef@uber.com> * In CI, fail if an update to yarn.lock is needed Signed-off-by: Joe Farro <joef@uber.com> * Misc cleanup Signed-off-by: Joe Farro <joef@uber.com> * Use stable yarn in CI Signed-off-by: Joe Farro <joef@uber.com> * Use yarn in package.json scripts Signed-off-by: Joe Farro <joef@uber.com> * Use newly downloaded yarn in CI Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

ghost assigned tiffon Jul 24, 2018

ghost added the review label Jul 24, 2018

tiffon commented Jul 24, 2018

View reviewed changes

tiffon and others added 4 commits July 31, 2018 11:41

Merge commit '7896416' into trace-diffs

8451213

Typo

db6e33f

Signed-off-by: Joe Farro <joef@uber.com>

Merge branch 'master' into trace-diffs

96774b9

tiffon force-pushed the trace-diffs branch from b145843 to 96774b9 Compare July 31, 2018 15:50

tiffon added 2 commits July 31, 2018 16:24

Fix #232 Split leaf from parent nodes in the tree

485eefb

Signed-off-by: Joe Farro <joef@uber.com>

Merge branch 'master' into trace-diffs

3d1edc8

Signed-off-by: Joe Farro <joef@uber.com>

tiffon requested a review from saminzadeh August 6, 2018 20:40

tiffon changed the title ~~[WIP] Trace diffs~~ Trace diffs Aug 6, 2018

plexus - Fix chart style issues and bump version

98f06d6

Also tweak the demo a bit. Signed-off-by: Joe Farro <joef@uber.com>

simonrobb approved these changes Aug 10, 2018

View reviewed changes

tiffon commented Aug 10, 2018

View reviewed changes

tiffon added 3 commits August 13, 2018 00:43

Fix yarn workspace based install

011ac73

Signed-off-by: Joe Farro <joef@uber.com>

In CI, fail if an update to yarn.lock is needed

3e81de9

Signed-off-by: Joe Farro <joef@uber.com>

Misc cleanup

2538fba

Signed-off-by: Joe Farro <joef@uber.com>

tiffon added 3 commits August 13, 2018 01:37

Use stable yarn in CI

088a58f

Signed-off-by: Joe Farro <joef@uber.com>

Use yarn in package.json scripts

d4c3ead

Signed-off-by: Joe Farro <joef@uber.com>

Use newly downloaded yarn in CI

ee39701

Signed-off-by: Joe Farro <joef@uber.com>

saminzadeh approved these changes Aug 14, 2018

View reviewed changes

yurishkuro merged commit d148dc5 into master Aug 14, 2018

ghost removed the review label Aug 14, 2018

yurishkuro deleted the trace-diffs branch January 29, 2020 15:08

snyk-bot mentioned this pull request Oct 30, 2020

[Snyk] Upgrade dagre from 0.7.4 to 0.8.5 m3ntalsp00n/jaeger-ui#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Trace diffs #228

Trace diffs #228

tiffon commented Jul 24, 2018 •

edited

Loading

tiffon Jul 24, 2018

tiffon commented Aug 6, 2018

tiffon commented Aug 6, 2018

simonrobb left a comment

simonrobb Aug 8, 2018

simonrobb Aug 9, 2018

simonrobb Aug 9, 2018

tiffon Aug 10, 2018

simonrobb Aug 9, 2018

tiffon left a comment

codecov bot commented Aug 13, 2018 •

edited

Loading

		}

		// export default withRouter(connect(mapStateToProps)(PageImpl));

Trace diffs #228

Trace diffs #228

Conversation

tiffon commented Jul 24, 2018 • edited Loading

Which problem is this PR solving?

Short description of the changes

Screenshots

Search results

Search results with several selected traces

Search results scrolled

HotROD demo

Comparing two traces from the HotROD demo

Mouseover effect shows the node at full zoom

Zoom in to full size

Cohort selection

Excerpt of a larger trace

tiffon Jul 24, 2018

Choose a reason for hiding this comment

tiffon commented Aug 6, 2018

tiffon commented Aug 6, 2018

simonrobb left a comment

Choose a reason for hiding this comment

simonrobb Aug 8, 2018

Choose a reason for hiding this comment

simonrobb Aug 9, 2018

Choose a reason for hiding this comment

simonrobb Aug 9, 2018

Choose a reason for hiding this comment

tiffon Aug 10, 2018

Choose a reason for hiding this comment

simonrobb Aug 9, 2018

Choose a reason for hiding this comment

tiffon left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 13, 2018 • edited Loading

Codecov Report

tiffon commented Jul 24, 2018 •

edited

Loading

codecov bot commented Aug 13, 2018 •

edited

Loading