Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Span Search - Highlight search results #238

Merged
merged 16 commits into from Oct 1, 2018

Conversation

Projects
None yet
2 participants
@davit-y
Copy link
Contributor

commented Aug 23, 2018

Which problem is this PR solving?

Short description of the changes

  • No longer drop opacity of spans that don't match filter
  • Highlight those that do

"Highlight matching spans" is the first commit of this branch, PR will be cleaner once #234 is merged

davit-y added some commits Aug 13, 2018

Add result count, navigation and clear buttons
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Correct imports
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Move and delete files
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Review fixes
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Fix TracePageHeader test
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Lighten buttons when disabled
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Review fixes
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Fix tests
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Add shortcuts
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Fix merge changes
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Fix TracePageHeader and TracePageSearchBar tests
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
@davit-y

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2018

Screenshots

screen shot 2018-08-23 at 2 16 52 pm

screen shot 2018-08-23 at 2 17 54 pm

@davit-y davit-y referenced this pull request Aug 23, 2018

Closed

Improved Span Search #235

0 of 3 tasks complete

davit-y added some commits Aug 24, 2018

Delay TracePageHeader testing until release of Enzyme v3.5.0
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Highlight matching spans
Signed-off-by: Davit Yeghshatyan <davo@uber.com>
Highlight span-name-wrapper
Signed-off-by: Davit Yeghshatyan <davo@uber.com>

@davit-y davit-y force-pushed the davit-y:search-highlight branch from a37a8d8 to 9bb150a Aug 24, 2018

@codecov

This comment has been minimized.

Copy link

commented Aug 24, 2018

Codecov Report

Merging #238 into master will decrease coverage by 1.08%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   78.61%   77.53%   -1.09%     
==========================================
  Files         135      135              
  Lines        2927     2933       +6     
  Branches      607      607              
==========================================
- Hits         2301     2274      -27     
- Misses        495      522      +27     
- Partials      131      137       +6
Impacted Files Coverage Δ
...components/TracePage/TracePageSearchBar.markers.js 100% <ø> (ø)
...nts/TracePage/TraceTimelineViewer/SpanDetailRow.js 100% <ø> (ø) ⬆️
...onents/TracePage/TraceTimelineViewer/SpanBarRow.js 80% <ø> (ø) ⬆️
.../components/TracePage/TraceTimelineViewer/index.js 100% <ø> (ø) ⬆️
...c/components/TracePage/TraceTimelineViewer/duck.js 100% <ø> (ø) ⬆️
...-ui/src/components/TracePage/keyboard-shortcuts.js 81.81% <ø> (ø) ⬆️
.../src/components/TracePage/KeyboardShortcutsHelp.js 20% <ø> (-13.34%) ⬇️
...ger-ui/src/components/TracePage/TracePageHeader.js 70% <0%> (-10%) ⬇️
...cePage/TraceTimelineViewer/VirtualizedTraceView.js 93.45% <100%> (-0.41%) ⬇️
...ckages/jaeger-ui/src/components/TracePage/index.js 76.1% <28.57%> (-18.95%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d148dc5...9bb150a. Read the comment docs.

@ghost ghost assigned tiffon Sep 27, 2018

@ghost ghost added the review label Sep 27, 2018

@codecov

This comment has been minimized.

Copy link

commented Sep 27, 2018

Codecov Report

Merging #238 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   77.05%   77.15%   +0.09%     
==========================================
  Files         135      135              
  Lines        2951     2950       -1     
  Branches      614      613       -1     
==========================================
+ Hits         2274     2276       +2     
+ Misses        534      531       -3     
  Partials      143      143
Impacted Files Coverage Δ
...nts/TracePage/TraceTimelineViewer/SpanDetailRow.js 100% <ø> (ø) ⬆️
...onents/TracePage/TraceTimelineViewer/SpanBarRow.js 80% <ø> (ø) ⬆️
...cePage/TraceTimelineViewer/VirtualizedTraceView.js 93.45% <100%> (-0.07%) ⬇️
...neViewer/TimelineHeaderRow/TimelineViewingLayer.js 92.59% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35841f7...fc115eb. Read the comment docs.

@tiffon

tiffon approved these changes Oct 1, 2018

Copy link
Member

left a comment

Great work!

@tiffon tiffon merged commit d7c7e10 into jaegertracing:master Oct 1, 2018

5 checks passed

DCO DCO
Details
WIP ready for review
Details
codecov/patch 100% of diff hit (target 77.05%)
Details
codecov/project 77.15% (+0.09%) compared to 35841f7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ghost ghost removed the review label Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.