Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #269 - Fix column resizer overlays trace header #280

Merged
merged 3 commits into from
Dec 17, 2018

Conversation

tiffon
Copy link
Member

@tiffon tiffon commented Nov 25, 2018

Signed-off-by: Joe Farro joef@uber.com

Which problem is this PR solving?

Fix #269.

Short description of the changes

HTML / CSS adjustments for the column resizer and a misc tweak to the collapse-all buttons so they have a hover state.

Signed-off-by: Joe Farro <joef@uber.com>
@ghost ghost assigned tiffon Nov 25, 2018
@ghost ghost added the review label Nov 25, 2018
@tiffon tiffon changed the title Fix #269 - Column resizer overlays trace header Fix #269 - Fix column resizer overlays trace header Nov 25, 2018
@codecov
Copy link

codecov bot commented Nov 25, 2018

Codecov Report

Merging #280 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
+ Coverage   77.52%   77.58%   +0.06%     
==========================================
  Files         137      137              
  Lines        2976     2976              
  Branches      617      617              
==========================================
+ Hits         2307     2309       +2     
+ Misses        528      526       -2     
  Partials      141      141
Impacted Files Coverage Δ
...eViewer/TimelineHeaderRow/TimelineColumnResizer.js 92.85% <100%> (ø) ⬆️
...neViewer/TimelineHeaderRow/TimelineViewingLayer.js 90.74% <0%> (+3.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae37289...c874464. Read the comment docs.

@tiffon tiffon merged commit f51dfd7 into master Dec 17, 2018
@ghost ghost removed the review label Dec 17, 2018
@yurishkuro yurishkuro deleted the issue-269-column-resizer branch January 29, 2020 15:08
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
…racing#280)

Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants