Add popover and prevent submit if duration params are invalid (#244) #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
==========================================
+ Coverage 82.23% 82.36% +0.13%
==========================================
Files 141 141
Lines 3112 3119 +7
Branches 647 651 +4
==========================================
+ Hits 2559 2569 +10
+ Misses 439 436 -3
Partials 114 114
Continue to review full report at Codecov.
|
|
I would rather display an error in the UI than try to infer which units the user had in mind by typing just a number. E.g. |
|
Per @yurishkuro comment, we can add a
The message only shows up if the user tries to submit the form while the field is invalid. To take it a bit further, the
|
tiffon
reviewed
Dec 17, 2018
| @@ -98,6 +99,11 @@ export function convertQueryParamsToFormDates({ start, end }) { | |||
| }; | |||
| } | |||
|
|
|||
| function addDefaultUnitToDuration(duration) { | |||
| if (!duration) return null; | |||
| return /[0-9]$/.test(duration) ? `${duration}ms` : duration; | |||
There was a problem hiding this comment.
Side note: 1.1 would fail this regex.
There was a problem hiding this comment.
This was just testing that if it ended in a number, append 'ms'. 1.1 ends in a number so it would pass. Regardless, I updated to your stronger pattern (but added a $ because 0ms0 would pass that pattern).
Signed-off-by: Everett Ross <reverett@uber.com>
everett980
force-pushed
the
issue-244-add-default-unit-to-duration-query-params
branch
from
a57d15d
to
b7616b9
Compare
ghost
assigned Signed-off-by: Everett Ross <reverett@uber.com>
everett980
changed the title
Signed-off-by: Everett Ross <reverett@uber.com>
tiffon
suggested changes
Dec 29, 2018
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
tiffon
approved these changes
Jan 4, 2019
packages/jaeger-ui/src/components/SearchTracePage/SearchForm.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
everett980
added a commit
to everett980/jaeger-ui
that referenced
this pull request
Jan 16, 2019
…tracing#244) (jaegertracing#291) * Add validation for duration fields in SearchForm (jaegertracing#244) Signed-off-by: Everett Ross <reverett@uber.com> * Add tests for redux-form-field-adapter Signed-off-by: Everett Ross <reverett@uber.com> * Fix boolean prop type Signed-off-by: Everett Ross <reverett@uber.com> * Add boolean for input validation, change popover to show when inactive Signed-off-by: Everett Ross <reverett@uber.com> * Add tests for onChangeAdapter Signed-off-by: Everett Ross <reverett@uber.com> * Create separate ValidatedAdaptedInput for duration fields Signed-off-by: Everett Ross <reverett@uber.com> * Remove unnecessary curly braces Signed-off-by: Everett Ross <reverett@uber.com> Signed-off-by: Everett Ross <reverett@uber.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
…tracing#244) (jaegertracing#291) * Add validation for duration fields in SearchForm (jaegertracing#244) Signed-off-by: Everett Ross <reverett@uber.com> * Add tests for redux-form-field-adapter Signed-off-by: Everett Ross <reverett@uber.com> * Fix boolean prop type Signed-off-by: Everett Ross <reverett@uber.com> * Add boolean for input validation, change popover to show when inactive Signed-off-by: Everett Ross <reverett@uber.com> * Add tests for onChangeAdapter Signed-off-by: Everett Ross <reverett@uber.com> * Create separate ValidatedAdaptedInput for duration fields Signed-off-by: Everett Ross <reverett@uber.com> * Remove unnecessary curly braces Signed-off-by: Everett Ross <reverett@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
…tracing#244) (jaegertracing#291) * Add validation for duration fields in SearchForm (jaegertracing#244) Signed-off-by: Everett Ross <reverett@uber.com> * Add tests for redux-form-field-adapter Signed-off-by: Everett Ross <reverett@uber.com> * Fix boolean prop type Signed-off-by: Everett Ross <reverett@uber.com> * Add boolean for input validation, change popover to show when inactive Signed-off-by: Everett Ross <reverett@uber.com> * Add tests for onChangeAdapter Signed-off-by: Everett Ross <reverett@uber.com> * Create separate ValidatedAdaptedInput for duration fields Signed-off-by: Everett Ross <reverett@uber.com> * Remove unnecessary curly braces Signed-off-by: Everett Ross <reverett@uber.com> Signed-off-by: Everett Ross <reverett@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
If the user times in an invalid duration, a popover is displayed to indicate that units are necessary. The submit button is disabled if any fields are invalid. To avoid jumping on the user as soon as the start typing, the popover is not visible until the user has blurred. After the user has blurred, the popover is visible as long as the field is invalid, even if the field becomes focused again.