Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive the changelog #300

Merged
merged 6 commits into from
Jan 12, 2019
Merged

Revive the changelog #300

merged 6 commits into from
Jan 12, 2019

Conversation

tiffon
Copy link
Member

@tiffon tiffon commented Dec 21, 2018

Which problem is this PR solving?

The changelog is out of date.

Short description of the changes

Bringing the changelog current.

Also, this switches to a format where we formally bless master as release ready by cutting a release in GitHub.

Signed-off-by: Joe Farro <joef@uber.com>
@ghost ghost assigned tiffon Dec 21, 2018
@ghost ghost added the review label Dec 21, 2018
@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #300 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   82.57%   82.57%           
=======================================
  Files         140      140           
  Lines        3151     3151           
  Branches      651      651           
=======================================
  Hits         2602     2602           
  Misses        438      438           
  Partials      111      111

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d61767a...33cc1cd. Read the comment docs.

Copy link
Collaborator

@everett980 everett980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the distinction between Next and Changes merged into master? Seems like the 4 PRs currently under Next are all also part of master but not listed under Changes merged into master

@tiffon
Copy link
Member Author

tiffon commented Jan 9, 2019

@everett980 Historically, we haven't used semantic versioning with the UI because we have had only minimal API contracts. We just merged everything to master and the jaeger repo would pull in the changes as they saw fit. However, now that we've added embedded mode (#263 followed by #286) we've exposed an API by way of the query parameters used to configure the embedded views.

It seems prudent to start using semantic versioning to indicate whether or not changes have any impact on our API contract(s). With this approach, a set of changes merged to master but not yet characterized by a semantic version can be considered unreleased.

The Changes merged into master are already released in Jaeger 1.8.2.

Copy link
Collaborator

@everett980 everett980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, once we have done a few releases we'll probably want a (fairly short) document on the release process.

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
@tiffon tiffon merged commit 52780c8 into master Jan 12, 2019
@ghost ghost removed the review label Jan 12, 2019
everett980 pushed a commit to everett980/jaeger-ui that referenced this pull request Jan 16, 2019
* Revive the changelog

Signed-off-by: Joe Farro <joef@uber.com>

* Add helper script to generate CHANGELOG entries

Signed-off-by: Joe Farro <joef@uber.com>

* One more changelog item, fix date typo

Signed-off-by: Joe Farro <joef@uber.com>

* Fix phrasing in changelog

Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
@yurishkuro yurishkuro deleted the revive-changelog branch January 29, 2020 15:07
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
* Revive the changelog

Signed-off-by: Joe Farro <joef@uber.com>

* Add helper script to generate CHANGELOG entries

Signed-off-by: Joe Farro <joef@uber.com>

* One more changelog item, fix date typo

Signed-off-by: Joe Farro <joef@uber.com>

* Fix phrasing in changelog

Signed-off-by: Joe Farro <joef@uber.com>

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
* Revive the changelog

Signed-off-by: Joe Farro <joef@uber.com>

* Add helper script to generate CHANGELOG entries

Signed-off-by: Joe Farro <joef@uber.com>

* One more changelog item, fix date typo

Signed-off-by: Joe Farro <joef@uber.com>

* Fix phrasing in changelog

Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants