Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JS errors on search form dropdowns (#325) #329

Merged
merged 2 commits into from
Feb 15, 2019
Merged

Fix JS errors on search form dropdowns (#325) #329

merged 2 commits into from
Feb 15, 2019

Conversation

tiffon
Copy link
Member

@tiffon tiffon commented Feb 15, 2019

Fix #325.

@tiffon
Fix JS errors on search form dropdowns (#325)
3ef1ac8 
Signed-off-by: Joe Farro <joef@uber.com>
@ghost ghost assigned tiffon Feb 15, 2019
@ghost ghost added the review label Feb 15, 2019
everett980
everett980 approved these changes Feb 15, 2019
View reviewed changes
Copy link
Collaborator

@everett980 everett980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@tiffon
Fix formatting issue
0bf673b 
Signed-off-by: Joe Farro <joef@uber.com>
@codecov
Copy link

codecov bot commented Feb 15, 2019 •
edited
Loading

Codecov Report

Merging #329 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   83.03%   83.04%   +<.01%     
==========================================
  Files         142      142              
  Lines        3148     3149       +1     
  Branches      649      649              
==========================================
+ Hits         2614     2615       +1     
  Misses        427      427              
  Partials      107      107
Impacted Files Coverage Δ
...es/jaeger-ui/src/utils/redux-form-field-adapter.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d0e712...0bf673b. Read the comment docs.

@tiffon tiffon merged commit eaeae68 into master Feb 15, 2019
@ghost ghost removed the review label Feb 15, 2019
@yurishkuro yurishkuro deleted the issue-325-search-dropdowns branch January 29, 2020 15:07
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
@tiffon
Fix JS errors on search form dropdowns (jaegertracing#325) (jaegertra…
73c480f 
…cing#329)

* Fix JS errors on search form dropdowns (jaegertracing#325)
* Fix formatting issue

Signed-off-by: Joe Farro <joef@uber.com>

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everett980 everett980 everett980 approved these changes

Assignees

@tiffon tiffon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tiffon @everett980