Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #241, extra vertical scrollbar in trace timeline view #350

Merged
merged 2 commits into from
Mar 19, 2019
Merged

Fix #241, extra vertical scrollbar in trace timeline view #350

merged 2 commits into from
Mar 19, 2019

Conversation

tiffon
Copy link
Member

@tiffon tiffon commented Mar 19, 2019

Fix #241.

@tiffon
Fix #241, extra vertical scrollbar in trace detail
5196384 
Signed-off-by: Joe Farro <joef@uber.com>
@tiffon tiffon requested a review from everett980 March 19, 2019 16:29
@ghost ghost assigned tiffon Mar 19, 2019
@ghost ghost added the review label Mar 19, 2019
@tiffon
Fix typo
788e3d5 
Signed-off-by: Joe Farro <joef@uber.com>
@codecov
Copy link

codecov bot commented Mar 19, 2019 •
edited
Loading

Codecov Report

Merging #350 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
+ Coverage   90.69%   90.69%   +<.01%     
==========================================
  Files         152      152              
  Lines        3288     3290       +2     
  Branches      666      666              
==========================================
+ Hits         2982     2984       +2     
  Misses        251      251              
  Partials       55       55
Impacted Files Coverage Δ
...ts/TracePage/TraceTimelineViewer/ListView/index.js 96.18% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faf6fc9...788e3d5. Read the comment docs.

everett980
everett980 approved these changes Mar 19, 2019
View reviewed changes
Copy link
Collaborator

@everett980 everett980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiffon tiffon merged commit 4f78dcf into master Mar 19, 2019
@ghost ghost removed the review label Mar 19, 2019
@yurishkuro yurishkuro deleted the issue-241-extra-scrollbar branch January 29, 2020 15:08
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
@tiffon
Merge pull request jaegertracing#350 from jaegertracing/issue-241-ext…
42d9331 
…ra-scrollbar

Fix jaegertracing#241, extra vertical scrollbar in trace timeline view
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everett980 everett980 everett980 approved these changes

Assignees

@tiffon tiffon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tiffon @everett980