Improve display of long operation names in Operations list #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some services like Traefik can generate really long operation names. Don't wrap the names in the Operation list so that they don't overlap each other. Signed-off-by: King Chung Huang <kinghuang@mac.com>
Pass the operation name as the title for VirtSelect options. This provides a way to see the full value of really long operation names that may be truncated by the width of the virtual select list. Signed-off-by: King Chung Huang <kinghuang@mac.com>
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
=======================================
Coverage 90.69% 90.69%
=======================================
Files 152 152
Lines 3290 3290
Branches 666 666
=======================================
Hits 2984 2984
Misses 251 251
Partials 55 55
Continue to review full report at Codecov.
|
ghost
assigned 
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
…flow Improve display of long operation names in Operations list Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Services like Traefik can generate really long operation names. These names wrap in the Operation search list, making options unreadable. This PR improves the display of really long operation names in the list.
Resolves #349
Short description of the changes
white-space: nowrapon.VirtSelect--optionelements.titlefor select options, so that the full value of really long operation names can be seen.