Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate when tags and/or references fields are arrays. #382

Merged

Conversation

rubenvp8510
Copy link
Collaborator

Signed-off-by: Ruben Vargas ruben.vp8510@gmail.com

Which problem is this PR solving?

Short description of the changes

  • Just validate those cases.

@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #382 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
+ Coverage   89.01%   89.07%   +0.06%     
==========================================
  Files         162      162              
  Lines        3658     3660       +2     
  Branches      831      833       +2     
==========================================
+ Hits         3256     3260       +4     
+ Misses        366      364       -2     
  Partials       36       36
Impacted Files Coverage Δ
...kages/jaeger-ui/src/model/transform-trace-data.tsx 85.07% <100%> (+0.45%) ⬆️
...eViewer/TimelineHeaderRow/TimelineViewingLayer.tsx 91.52% <0%> (+3.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ca6ca7...2bccab4. Read the comment docs.

Copy link
Collaborator

@everett980 everett980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another PR!

Rather than have checks for incomplete data, this function could sanitize incomplete data so that all parts of the app can rely on the expected structure of Spans.

packages/jaeger-ui/src/model/transform-trace-data.tsx Outdated Show resolved Hide resolved
@rubenvp8510
Copy link
Collaborator Author

I did the property changes, I think this is ready for another review. Sorry for the delay.

Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
@everett980
Copy link
Collaborator

LGTM, thanks @rubenvp8510 !

@everett980 everett980 merged commit 530d2c7 into jaegertracing:master Jun 13, 2019
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
…eferences

Validate when tags and/or references fields are arrays.
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants