Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap span tag values #388

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Wrap span tag values #388

merged 1 commit into from
Jun 10, 2019

Conversation

epkugelmass
Copy link
Contributor

Which problem is this PR solving?

Long tag values are difficult to read as they are rendered in a scroll box.

Short description of the changes

Wrap the tag value instead.

From

image

to

image

Signed-off-by: Elan Kugelmass epkugelmass@gmail.com

@yurishkuro
Copy link
Member

I can see arguments for either type of display, e.g. a huge value that's not relevant to you at the moment will mess up the display. Maybe this should be toggled somehow.

Signed-off-by: Elan Kugelmass <epkugelmass@gmail.com>
@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #388 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #388   +/-   ##
=======================================
  Coverage   89.06%   89.06%           
=======================================
  Files         162      162           
  Lines        3658     3658           
  Branches      831      831           
=======================================
  Hits         3258     3258           
  Misses        364      364           
  Partials       36       36

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2abec69...8068248. Read the comment docs.

@epkugelmass
Copy link
Contributor Author

I can see arguments for either type of display, e.g. a huge value that's not relevant to you at the moment will mess up the display. Maybe this should be toggled somehow.

I agree with you. This measly PR represents the limit of what I'm able to contribute to this project right now. Maybe we should close this in favor of a more detailed issue.

@tiffon
Copy link
Member

tiffon commented Jun 10, 2019

@yurishkuro values don't get very large due to truncation.

Copy link
Member

@tiffon tiffon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

Copy link
Member

@tiffon tiffon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@tiffon tiffon merged commit 1ca6ca7 into jaegertracing:master Jun 10, 2019
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Wrap span tag values
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants