Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more GA events, fix clear uiFind & kbd modal #470

Merged

Conversation

everett980
Copy link
Collaborator

Which problem is this PR solving?

  • Some user actions of interest were not being tracked, two user actions weren't being tracked correctly.

Short description of the changes

  • Track keyboard shortcut modal open event on modal open, not on render.
  • Track uiFind clear events caused by clicking clear button or hitting escape, not just when deleting all characters in input.
    • Do not track uiFind events when value is unchanged (e.g. spamming esc, or clicking blurring input without typing)
  • Track trace timeline uiFind interactions (focus, next, prev)
  • Track use of new Search Results Ddg

Signed-off-by: Everett Ross <reverett@uber.com>
@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #470 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
+ Coverage   92.24%   92.31%   +0.07%     
==========================================
  Files         192      193       +1     
  Lines        4477     4492      +15     
  Branches     1071     1072       +1     
==========================================
+ Hits         4130     4147      +17     
+ Misses        305      303       -2     
  Partials       42       42
Impacted Files Coverage Δ
.../components/SearchTracePage/SearchResults/index.js 80.76% <100%> (+0.76%) ⬆️
...jaeger-ui/src/components/TracePage/index.track.tsx 100% <100%> (ø) ⬆️
...racePage/TracePageHeader/KeyboardShortcutsHelp.tsx 95.83% <100%> (+8.33%) ⬆️
...kages/jaeger-ui/src/components/TracePage/index.tsx 100% <100%> (ø) ⬆️
...ents/SearchTracePage/SearchResults/index.track.tsx 100% <100%> (ø)
packages/jaeger-ui/src/utils/update-ui-find.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d93b8e8...68ee294. Read the comment docs.

@everett980 everett980 merged commit c3e73af into jaegertracing:master Oct 29, 2019
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
…-timeline

Add more GA events, fix clear uiFind & kbd modal
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants