Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ddg optional operation #488

Merged
merged 5 commits into from
Nov 25, 2019

Conversation

everett980
Copy link
Collaborator

Which problem is this PR solving?

  • Current DDG is a service & operation oriented dependency graph. We want to be able to have a service dependency graph.

Short description of the changes

  • Allow operation field on focal vertex to be an array (filtered based on visibility)
  • Raise request when service is specified
  • Allow operation to be cleared
  • Allow operation to be specified on focal node with multiple operations
  • Improve DDG node hovered CSS

Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #488 into master will increase coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
+ Coverage   92.47%   92.71%   +0.23%     
==========================================
  Files         193      193              
  Lines        4611     4652      +41     
  Branches     1101     1119      +18     
==========================================
+ Hits         4264     4313      +49     
+ Misses        305      299       -6     
+ Partials       42       40       -2
Impacted Files Coverage Δ
...ui/src/components/DeepDependencies/Graph/index.tsx 100% <ø> (ø) ⬆️
...er-ui/src/model/ddg/sample-paths.test.resources.js 100% <ø> (ø) ⬆️
...ndencies/Graph/DdgNodeContent/calc-positioning.tsx 100% <100%> (ø) ⬆️
packages/jaeger-ui/src/utils/update-ui-find.tsx 100% <100%> (ø) ⬆️
...ui/src/components/DeepDependencies/index.track.tsx 100% <100%> (ø) ⬆️
...kages/jaeger-ui/src/model/ddg/GraphModel/index.tsx 100% <100%> (ø) ⬆️
...ts/DeepDependencies/Graph/DdgNodeContent/index.tsx 100% <100%> (ø) ⬆️
...aeger-ui/src/components/DeepDependencies/index.tsx 100% <100%> (ø) ⬆️
...i/src/components/DeepDependencies/Header/index.tsx 100% <100%> (ø) ⬆️
...onents/DeepDependencies/Graph/getNodeRenderers.tsx 100% <100%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ee8da1...6073c75. Read the comment docs.

@everett980
Copy link
Collaborator Author

Build passed but never updated on this view...

@everett980 everett980 merged commit 0c175e1 into jaegertracing:master Nov 25, 2019
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
…ration

Ddg optional operation
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants