Configure search.maxLimit #511
Conversation
Codecov Report
@@ Coverage Diff @@
## master #511 +/- ##
==========================================
+ Coverage 92.87% 92.89% +0.02%
==========================================
Files 197 197
Lines 4814 4814
Branches 1162 1162
==========================================
+ Hits 4471 4472 +1
+ Misses 302 301 -1
Partials 41 41
Continue to review full report at Codecov.
|
Signed-off-by: Gabriel Fernando Dyck <gabriel.dyck@despegar.com>
GabrielDyck
force-pushed
the
squash-master
branch
from
f1b1d06
to
6a7a3d3
Compare
There was a problem hiding this comment.
The diff LGTM 👍
@yurishkuro can you advise on how to contribute to the ui-config.json documentation?
|
it should go into this file: https://github.com/jaegertracing/documentation/blob/master/content/docs/next-release/frontend-ui.md |
|
Hello! I've added documentation for this in the PR jaegertracing/documentation#348 Let me know if it's ok. |
| @@ -443,7 +443,7 @@ export class SearchFormImpl extends React.PureComponent { | |||
| type="number" | |||
| component={AdaptedInput} | |||
| placeholder="Limit Results" | |||
| props={{ disabled, min: 1, max: 1500 }} | |||
There was a problem hiding this comment.
does the default-config below provide defaults per value, or only as a whole configuration?
There was a problem hiding this comment.
It takes default per value.
If we configure maxLimit as 500, It will take 500. If the value "maxLimit" isn't configure, it will take the default value, in this case, 1500.
@everett980 could you tell me if I am wrong?
Thank you!
There was a problem hiding this comment.
@GabrielDyck you are correct. default-config is consumed per value.
* Add jaeger-ui search input documentation Signed-off-by: Gabriel Fernando Dyck <gabriel.dyck@despegar.com> * Add search input config detail Signed-off-by: Gabriel Fernando Dyck <gabriel.dyck@despegar.com> * Improve documentation for search configuration. Signed-off-by: Gabriel Fernando Dyck <gabriel.dyck@despegar.com> * Improve search input limit doc. Signed-off-by: Gabriel Fernando Dyck <gabriel.dyck@despegar.com>
|
Documentation was merged, so this LGTM. Thanks for your patience! |
Signed-off-by: Gabriel Fernando Dyck <gabriel.dyck@despegar.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Signed-off-by: Gabriel Fernando Dyck gabrielfernandodyck@gmail.com
Which problem is this PR solving?