Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track trace alt views #512

Merged
merged 4 commits into from
Jan 14, 2020

Conversation

everett980
Copy link
Collaborator

Which problem is this PR solving?

  • Currently we only track viewing a trace as a graph, and we call that "Open" without tracking other trace views.

Short description of the changes

  • Track other trace views (JSON, JSON (unadjusted))
  • Rename viewing trace graph event to better reflect what it is
  • Track when user returns to Gantt chart after viewing another view

Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@97655e2). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #512   +/-   ##
=========================================
  Coverage          ?   92.96%           
=========================================
  Files             ?      197           
  Lines             ?     4807           
  Branches          ?     1159           
=========================================
  Hits              ?     4469           
  Misses            ?      297           
  Partials          ?       41
Impacted Files Coverage Δ
.../components/SearchTracePage/SearchResults/index.js 80.76% <ø> (ø)
...aeger-ui/src/components/DeepDependencies/index.tsx 100% <100%> (ø)
...s/SearchTracePage/SearchResults/AltViewOptions.tsx 100% <100%> (ø)
...nents/TracePage/TracePageHeader/AltViewOptions.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97655e2...24c83b5. Read the comment docs.

Signed-off-by: Everett Ross <reverett@uber.com>
@everett980 everett980 merged commit 521c2d0 into jaegertracing:master Jan 14, 2020
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
* Track trace alt views, TODO:test AltViewOptions

Signed-off-by: Everett Ross <reverett@uber.com>

* Fix year

Signed-off-by: Everett Ross <reverett@uber.com>

* Test AltViewOptions.tsx, rename toggle ddg prop

Signed-off-by: Everett Ross <reverett@uber.com>

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants