Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor model/trace-dag to prep for latency diffs #521

Merged
merged 2 commits into from
Mar 26, 2020
Merged

Refactor model/trace-dag to prep for latency diffs #521

merged 2 commits into from
Mar 26, 2020

Commits on Mar 22, 2020

  1. Refactor model/trace-dag to prep for latency diffs 

    - Refactor TraceDag class to make it simpler and more flexible

- Change DagNode to be a simple type instead of a class

- Change the data on DagNode to extend DagNode instead of live off
  the "data" field

- Base the data model for trace diffs on collections of DenseSpans
  instead of just the count of spans in a vs b for a given node in the
  comparison DAG

- Lay some small (id-factories.tsx) ground-work for being more flexible
  in how the DAG is built from the trace, which is to say how spans are
  grouped

Signed-off-by: Joe Farro <joe@jf.io>
    @tiffon
    tiffon committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    dc39cbe View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into trace-dag-refactor

    @tiffon
    tiffon committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    d59380d View commit details
    Browse the repository at this point in the history