Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uiFind matches for spans with leading 0s #567

Conversation

everett980
Copy link
Collaborator

Which problem is this PR solving?

Short description of the changes

  • Strip leading 0s out of filter string and spanID before comparing.

Signed-off-by: Everett Ross <reverett@uber.com>
@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #567 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
- Coverage   90.07%   90.05%   -0.02%     
==========================================
  Files         214      214              
  Lines        5210     5210              
  Branches     1327     1327              
==========================================
- Hits         4693     4692       -1     
- Misses        474      475       +1     
  Partials       43       43              
Impacted Files Coverage Δ
packages/jaeger-ui/src/utils/filter-spans.tsx 100.00% <100.00%> (ø)
...eViewer/TimelineHeaderRow/TimelineViewingLayer.tsx 88.13% <0.00%> (-1.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f960c47...ae6f6eb. Read the comment docs.

@everett980 everett980 merged commit 7b5aecd into jaegertracing:master Apr 29, 2020
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UiFind does not match spanID with leading 0
2 participants