Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support client versions table in details card #568

Conversation

everett980
Copy link
Collaborator

Which problem is this PR solving?

  • Allow clients version table to be displayed within its corresponding <MetricCard />, rather than as a standalone table at the bottom.

Short description of the changes

  • Accept TExample[] as a row value
  • Make qualityMetrics.clientVersions optional, soon to be removed.

Signed-off-by: Everett Ross <reverett@uber.com>
@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #568 into master will decrease coverage by 0.17%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #568      +/-   ##
==========================================
- Coverage   90.10%   89.92%   -0.18%     
==========================================
  Files         214      214              
  Lines        5213     5221       +8     
  Branches     1328     1334       +6     
==========================================
- Hits         4697     4695       -2     
- Misses        473      483      +10     
  Partials       43       43              
Impacted Files Coverage Δ
...s/DeepDependencies/SidePanel/DetailsCard/index.tsx 2.94% <0.00%> (-0.29%) ⬇️
...ger-ui/src/components/QualityMetrics/CountCard.tsx 0.00% <ø> (ø)
...-ui/src/components/QualityMetrics/ExamplesLink.tsx 0.00% <ø> (ø)
.../jaeger-ui/src/components/QualityMetrics/index.tsx 0.00% <0.00%> (ø)
...eViewer/TimelineHeaderRow/TimelineViewingLayer.tsx 88.13% <0.00%> (-3.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b8a694...cd40a85. Read the comment docs.

@everett980 everett980 merged commit e01d90f into jaegertracing:master May 12, 2020
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants