Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render seconds in dark color, millis in light #605

Merged
merged 1 commit into from
Jul 26, 2020

Conversation

yurishkuro
Copy link
Member

Use light color only for the decimals, not the main hh:mm:ss timestamp

image

Signed-off-by: Yuri Shkuro <ys@uber.com>
@codecov
Copy link

codecov bot commented Jul 26, 2020

Codecov Report

Merging #605 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #605      +/-   ##
==========================================
- Coverage   93.54%   93.52%   -0.02%     
==========================================
  Files         217      217              
  Lines        5296     5296              
  Branches     1362     1362              
==========================================
- Hits         4954     4953       -1     
- Misses        301      302       +1     
  Partials       41       41              
Impacted Files Coverage Δ
...ents/TracePage/TracePageHeader/TracePageHeader.tsx 96.42% <100.00%> (ø)
...eViewer/TimelineHeaderRow/TimelineViewingLayer.tsx 88.13% <0.00%> (-5.09%) ⬇️
packages/jaeger-ui/src/utils/date.tsx 90.47% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ac8df2...18341d7. Read the comment docs.

@yurishkuro yurishkuro merged commit 89f0050 into jaegertracing:master Jul 26, 2020
@yurishkuro yurishkuro deleted the fix-starttime-seconds branch July 26, 2020 03:46
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant