Refactor SpanGraph.UNSAFE_componentWillReceiveProps #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #613 +/- ##
==========================================
+ Coverage 92.78% 92.84% +0.06%
==========================================
Files 227 227
Lines 5908 5902 -6
Branches 1490 1487 -3
==========================================
- Hits 5482 5480 -2
+ Misses 385 381 -4
Partials 41 41
Continue to review full report at Codecov.
|
tklever
force-pushed
the
refactor-UNSAFE-componentWillRecieveProps-spangraph
branch
from
7ddb539
to
666e07b
Compare
rubenvp8510
reviewed
Aug 14, 2020
packages/jaeger-ui/src/components/TracePage/TracePageHeader/SpanGraph/index.tsx
Show resolved
Hide resolved
|
This looks good, +1 on the memoization! |
yurishkuro
reviewed
Aug 15, 2020
packages/jaeger-ui/src/components/TracePage/TracePageHeader/SpanGraph/index.tsx
Show resolved
Hide resolved
This test codifies the sentiments on SpanGraph/index.tsx#L35, confirming that canvas graph is not re-rendered unless trace is changed Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>
Using component state in this manner is considered a react anti-pattern. By removing it, not only is the size and complexity of the component reduced, but it enables the removal of the legacy method UNSAFE_componentWillReceiveProps Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com>
tklever
force-pushed
the
refactor-UNSAFE-componentWillRecieveProps-spangraph
branch
from
666e07b
to
4844d1c
Compare
yurishkuro
reviewed
Aug 17, 2020
|
|
||
| export default class SpanGraph extends React.PureComponent<SpanGraphProps> { |
There was a problem hiding this comment.
React.PureComponent<SpanGraphProps>
IsSpanGraphProps still relevant? Seems like it was only affecting constructor/callback.
There was a problem hiding this comment.
ah, I guess it affects this.props in render()
yurishkuro
approved these changes
Aug 17, 2020
yurishkuro
changed the title
tklever
deleted the
refactor-UNSAFE-componentWillRecieveProps-spangraph
branch
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 4, 2021
* add test to ensure canvas graph rendering is limited This test codifies the sentiments on SpanGraph/index.tsx#L35, confirming that canvas graph is not re-rendered unless trace is changed Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com> * refactor SpanGraph to not use internal state for memoization Using component state in this manner is considered a react anti-pattern. By removing it, not only is the size and complexity of the component reduced, but it enables the removal of the legacy method UNSAFE_componentWillReceiveProps Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 4, 2021
* add test to ensure canvas graph rendering is limited This test codifies the sentiments on SpanGraph/index.tsx#L35, confirming that canvas graph is not re-rendered unless trace is changed Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com> * refactor SpanGraph to not use internal state for memoization Using component state in this manner is considered a react anti-pattern. By removing it, not only is the size and complexity of the component reduced, but it enables the removal of the legacy method UNSAFE_componentWillReceiveProps Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* add test to ensure canvas graph rendering is limited This test codifies the sentiments on SpanGraph/index.tsx#L35, confirming that canvas graph is not re-rendered unless trace is changed Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com> * refactor SpanGraph to not use internal state for memoization Using component state in this manner is considered a react anti-pattern. By removing it, not only is the size and complexity of the component reduced, but it enables the removal of the legacy method UNSAFE_componentWillReceiveProps Signed-off-by: Tim Klever <Tim.V.Klever@aexp.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
This was referenced Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes